- After adding tunnel headers, but before segmentation, packet length ca... #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… can be more than 65535. So, pkt_len() should return an integer rather than a short. Once segmentation happens, we anyway update the outer ip header length. So, whatever is updated in between (during the course of ip header addition), really doesn't matter. - Mirror bug: If the mirrored packet is TCP and is marked for GSO, we carry that gso type to mirror packet which is in-fact a UDP packet. So, correct the gso type, if the type is not what is expected for UDP packets
ghost
assigned
srajag
added a commit
that referenced
this pull request
Dec 11, 2013
- After adding tunnel headers, but before segmentation, packet length ca...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n be
more than 65535. So, pkt_len() should return an integer rather than a short.
Once segmentation happens, we anyway update the outer ip header length. So,
whatever is updated in between (during the course of ip header addition),
really doesn't matter.
that gso type to mirror packet which is in-fact a UDP packet. So, correct the
gso type, if the type is not what is expected for UDP packets