Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveScheduler.config.{guard_with,queue_name_resolver} #21

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

AMHOL
Copy link
Contributor

@AMHOL AMHOL commented Apr 1, 2021

This allows configuration of a custom guard clause to check whether jobs should be wrapped or not, as well as allowing for a custom queue_name_resolver configuration which will be called to resolve the queue name when the queue is not configured. The idea behind this is to enable an option which avoids the use of class_name.constantize, meaning that we don't have to load the entire Rails environment for the resque scheduler rake task and save some memory.

Alternative to #22

This allows configuration of a custom guard clause to check whether jobs should be wrapped or not, as well as allowing for a custom queue_name_resolver configuration which will be called to resolve the queue name when the queue is not configured. The idea behind this is to enable an option which avoids the use of "class_name.constantize", meaning that we don't have to load the entire Rails environment for the resque scheduler rake task and save some memory.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling d9593ed on AMHOL:feature/guard_with-and-queue_name_resolver-config into ee3a38c on JustinAiken:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants