fix: decode path parts in local web server (#369)

JustinBeckwith · Dec 18, 2021 · 4696a0c · 4696a0c
1 parent c9007cb
commit 4696a0c
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 1 deletion.
diff --git a/src/server.ts b/src/server.ts
@@ -46,7 +46,10 @@ async function handleRequest(
   options: WebServerOptions
 ) {
   const url = new URL(req.url || '/', `http://localhost:${options.port}`);
-  const pathParts = url.pathname.split('/').filter(x => !!x);
+  const pathParts = url.pathname
+    .split('/')
+    .filter(x => !!x)
+    .map(decodeURIComponent);
   const originalPath = path.join(root, ...pathParts);
   if (url.pathname.endsWith('/')) {
     pathParts.push('index.html');

diff --git a/test/fixtures/urlpatterns/funky+path.html b/test/fixtures/urlpatterns/funky+path.html
@@ -0,0 +1,3 @@
+<html>
+    <body>:waves:</body>
+</html>
diff --git a/test/fixtures/urlpatterns/index.html b/test/fixtures/urlpatterns/index.html
@@ -0,0 +1,3 @@
+<html>
+    <body><a href="funky%2Bpath.html">url with a +</a></body>
+</html>
diff --git a/test/test.index.ts b/test/test.index.ts
@@ -556,4 +556,12 @@ describe('linkinator', () => {
     const results = await check({path: 'test/fixtures/srcset'});
     assert.ok(results.passed);
   });
+
+  it('should handle encoded urls', async () => {
+    const results = await check({
+      serverRoot: 'test/fixtures/urlpatterns',
+      path: 'index.html',
+    });
+    assert.ok(results.passed);
+  });
 });