fix: preserve configuration for custom instance #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orgads
commented
Nov 16, 2023
| @@ -175,7 +175,7 @@ async function onError(error: AxiosError) { | |||
| config.retry = typeof config.retry === 'number' ? config.retry : 3; | |||
| config.retryDelay = | |||
| typeof config.retryDelay === 'number' ? config.retryDelay : 100; | |||
| config.instance = config.instance || axios; | |||
| config.instance = config.instance || instance; | |||
There was a problem hiding this comment.
I think config.instance can be deprecated following this change.
|
I haven't been paying a ton of attention to axios API changes, but this generally seems good if the tests pass 😆 Could I trouble you to run |
orgads
force-pushed
the
retry-instance
branch
from
ccef900
to
d6d6373
Compare
|
Done |
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #68.