WIP: Apache pieces #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JustinCally One Apache 2.0 piece I did not tackle is the description of changes in the relevant |
|
Thanks @stephhazlitt. I made some modifications to get through the checks and have removed my original MIT licence so that both myself and the Province of British Columbia are copyright holders. As Andy said, this is probably easier. I'll add the state changes for the R and test files over the next couple of days. |
|
This is looking great @stephhazlitt and @JustinCally - thanks! |
|
Looks good to me. Thanks to @stephhazlitt for doing the heavy lifting here. |
|
Thanks @stephhazlitt @ateucher @boshek If you are all happy I will accept the pull request and make a CRAN release |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to address items listed in Issue #25.
I suggest code reviews by @JustinCally @ateucher and @boshek before merge consideration.
Current state is an attempt to bring in the {bcdata} source code Apache 2.0 licence elements with modifications still licensed under MIT. A simplification would be to switch the modifications to the Apache 2.0 licence (tasks would be: rm LICENCE.md file, rename LICENCE-APACHE2.md -> LICENCE.md, rm MIT in footer of README, rm MIT from
DESCRIPTIONfile).