Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for A <: AbstractMatrix #64

Open
miakramer opened this issue Mar 15, 2022 · 1 comment
Open

Support for A <: AbstractMatrix #64

miakramer opened this issue Mar 15, 2022 · 1 comment

Comments

@miakramer
Copy link

Is there any particular reason the interface for Tensor requires A <: DenseMatrix for the storage type? Does this package assume column-major indexing, for example? If not, would a PR removing that requirement and instead requiring A <: AbstractMatrix be welcome?

@Jutho
Copy link
Owner

Jutho commented Mar 15, 2022

Almost all operations that you can do with Tensor(Map) objects, such as contractions and linear algebra factorizations, are currently only supported for DenseMatrix. Actually, in practice, typically only an implementation for Matrix is available; the parametric type is there to support CuArray in the (hopefully near) future. I thus don't quite see what you hope to gain by widening this to AbstractMatrix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants