This repository has been archived by the owner on Aug 30, 2022. It is now read-only.
Perform onConnectAction after assigning Gatt property #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A developer was unable to perform actions on their `Gatt` object if they
used the reference returned by `keepAliveGatt` extension function. For
example:
```
private val gatt: KeepAliveGatt = viewModelScope.keepAliveGatt(
application,
bluetoothDevice,
disconnectTimeoutMillis = 5_000L
) {
discoverServicesOrThrow()
gatt.writeCharacteristicOrThrow(...) // throws `NotReady` exception
}
```
By performing the `OnConnectAction` after the internal `Gatt` property
assignment, the `KeepAliveGatt` has the needed reference and won't throw
`NotReady` if a developer uses their own `Gatt` reference (provided from
`keepAliveGatt` extension function).
twyatt
force-pushed
the
twyatt/KeepAliveGatt-onConnectAction
branch
from
543f706
to
110d4b8
Compare
twyatt
requested review from
austinhobbs,
cedrickcooke,
Chris-Corea,
KVelasco,
QuantumRand and
sdonn3
Chris-Corea
approved these changes
Jun 30, 2020
cedrickcooke
approved these changes
Jul 7, 2020
sdonn3
reviewed
Jul 7, 2020
| _gatt = gatt | ||
| onConnectAction?.invoke(gatt) |
sdonn3
approved these changes
Jul 7, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A developer was unable to perform actions on their
Gattobject if they used the reference returned bykeepAliveGattextension function. For example:By performing the
OnConnectActionafter the internalGattproperty assignment, theKeepAliveGatthas the needed reference and won't throwNotReadyif a developer uses their ownGattreference (provided fromkeepAliveGattextension function).