Add basic threading strategy support #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twyatt
changed the title
This comment was marked as resolved.
This comment was marked as resolved.
twyatt
force-pushed
the
twyatt/threading-strategy
branch
from
76662a9
to
e6fd150
Compare
twyatt
force-pushed
the
twyatt/threading-strategy
branch
2 times, most recently
from
db51d83
to
ceba0b9
Compare
It was not needed for scan exception changes.
twyatt
force-pushed
the
twyatt/threading-strategy
branch
from
ceba0b9
to
e99c94c
Compare
twyatt
force-pushed
the
twyatt/threading-strategy
branch
from
e99c94c
to
ea0acd4
Compare
twyatt
requested review from
QuantumRand and
davidtaylor-juul
and removed request for
a team
QuantumRand
approved these changes
Aug 23, 2024
| guard.withLock { | ||
| pool.removeAll { (timeMark) -> timeMark.hasPassedNow() } | ||
| } | ||
| delay(evictAfter / 2) |
There was a problem hiding this comment.
Why half the eviction time? Sqrt might be a little more flexible.
There was a problem hiding this comment.
Was trying to find a balance between checking too often and not having threads stay alive for a lot longer than needed.
I do like sqrt for this, but unfortunately evictAfter is a Duration; whereas Duration.div(Int) is provided, but a Duration.sqrt function is not. I could convert to milliseconds for all durations, do the sqrt operation, then convert back, but that seems like an unnecessary amount of complexity for little gain?
Perhaps dividing by 3 would be better?
davidtaylor-juul
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #577.