Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kotlinx-metadata-jvm workaround #224

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

twyatt
Copy link
Member

@twyatt twyatt commented Nov 11, 2022

No description provided.

@twyatt twyatt added the maintenance General maintenance that doesn't effect the public API. label Nov 11, 2022
@github-actions
Copy link

Test Results

  32 files    32 suites   9s ⏱️
233 tests 226 ✔️   7 💤 0
250 runs  238 ✔️ 12 💤 0

Results for commit 3c96be3.

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #224 (3c96be3) into main (1c1547e) will decrease coverage by 8.98%.
The diff coverage is 80.27%.

@@             Coverage Diff              @@
##               main     #224      +/-   ##
============================================
- Coverage     94.44%   85.46%   -8.99%     
- Complexity       51       91      +40     
============================================
  Files            13       20       +7     
  Lines           126      282     +156     
  Branches          8       15       +7     
============================================
+ Hits            119      241     +122     
- Misses            6       37      +31     
- Partials          1        4       +3     
Impacted Files Coverage Δ
coroutines/src/commonMain/kotlin/flow/Combine.kt 0.00% <ø> (ø)
logging/src/commonMain/kotlin/Metadata.kt 76.92% <0.00%> (-0.86%) ⬇️
logging/src/commonMain/kotlin/Sensitivity.kt 0.00% <0.00%> (ø)
...tines/src/commonMain/kotlin/delay/DelayStrategy.kt 47.50% <47.50%> (ø)
logging/src/commonMain/kotlin/DispatchLogger.kt 92.10% <89.65%> (-7.90%) ⬇️
logging/src/commonMain/kotlin/Log.kt 98.27% <93.75%> (-1.73%) ⬇️
logging/src/commonMain/kotlin/FilterLogger.kt 95.65% <95.65%> (ø)
...t/src/commonMain/kotlin/TuulboxKtorClientLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/FilterLevelLogger.kt 100.00% <100.00%> (ø)
logging/src/commonMain/kotlin/LogLevel.kt 100.00% <100.00%> (ø)
... and 7 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@twyatt twyatt marked this pull request as ready for review November 11, 2022 22:21
@twyatt twyatt requested a review from a team as a code owner November 11, 2022 22:21
@cedrickcooke cedrickcooke merged commit 676d696 into main Nov 14, 2022
@cedrickcooke cedrickcooke deleted the twyatt/kotlinx-metadata-jvm branch November 14, 2022 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance General maintenance that doesn't effect the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants