-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dab-library CMakeLists.txt doesn't force C++ 11 support #7
Comments
Good point, I'll see to it.
Jan
2017-03-17 12:48 GMT+01:00 rickwookie <notifications@github.com>:
… To compile dab-library, the README file states: "IMPORTANT: YOU NEED C++11
SUPPORT FOR THIS", which I found to be the case (it wouldn't compile
without!), so could the CMakeLists.txt not include
'add_compile_options(-std=c++11)' to facilitate this, or does this
compile option break with newer versions of cmake (that perhaps already use
C++ 11 by default)?
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#7>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AITzwPjsfCtUj_XevQ2fPSRnz1n28D7Iks5rmnMJgaJpZM4Mgffj>
.
--
Jan van Katwijk
+31 (0)15 3698980
+31 (0) 628260355
|
Nice one, that now compiles as-is (with of course the un-commenting of the correct hardware type in the READ THIS section, as expected). Hopefully that hasn't broken it for anyone else with other versions of cmake. ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
To compile dab-library, the README file states: "IMPORTANT: YOU NEED C++11 SUPPORT FOR THIS", which I found to be the case (it wouldn't compile without!), so could the CMakeLists.txt not include 'add_compile_options(-std=c++11)' to facilitate this, or does this compile option break with newer versions of cmake (that perhaps already use C++ 11 by default)?
The text was updated successfully, but these errors were encountered: