Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dab-library CMakeLists.txt doesn't force C++ 11 support #7

Closed
rickwookie opened this issue Mar 17, 2017 · 2 comments
Closed

dab-library CMakeLists.txt doesn't force C++ 11 support #7

rickwookie opened this issue Mar 17, 2017 · 2 comments

Comments

@rickwookie
Copy link

To compile dab-library, the README file states: "IMPORTANT: YOU NEED C++11 SUPPORT FOR THIS", which I found to be the case (it wouldn't compile without!), so could the CMakeLists.txt not include 'add_compile_options(-std=c++11)' to facilitate this, or does this compile option break with newer versions of cmake (that perhaps already use C++ 11 by default)?

@JvanKatwijk
Copy link
Owner

JvanKatwijk commented Mar 17, 2017 via email

@rickwookie
Copy link
Author

Nice one, that now compiles as-is (with of course the un-commenting of the correct hardware type in the READ THIS section, as expected). Hopefully that hasn't broken it for anyone else with other versions of cmake. ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants