Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(folders): use API search endpoint for testing folder existence #262

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

ffapitalle
Copy link
Contributor

Uses the API search endpoint to check if a dashboard folder exists.

Former API endpoint returns only root level folders.

This is meant to be a step forward into the full support of nested folders mentioned in #261 .

@joeblubaugh
Copy link

I believe this needs a change to add an additional query paramter: /api/search?type=dash-folder. Otherwise, dashboards will also be returned by the search API.

@K-Phoen K-Phoen added the patch label Jun 18, 2024
@K-Phoen K-Phoen merged commit bb1093e into K-Phoen:master Jun 18, 2024
3 checks passed
@K-Phoen
Copy link
Owner

K-Phoen commented Jun 18, 2024

Merged, thanks for the PR :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants