Inspection number #60

K-Phoen · 2017-12-02T17:35:45Z

Fixes #38

K-Phoen · 2017-12-02T17:35:59Z

src/GithubContext/Application/CommandHandler/Inspection/SchedulePullRequest.php

        // create the inspection
-        $inspection = Entity\PullRequestInspection::create($repository, $pullRequest);
+        $inspection = Entity\PullRequestInspection::create($repository, $pullRequest, $number);


[phpmd]

Avoid using static access to class '\Regis\GithubContext\Domain\Entity\PullRequestInspection' in method 'handle'.

K-Phoen · 2017-12-02T17:36:00Z

src/GithubContext/Infrastructure/Repository/DoctrinePullRequestInspections.php

@@ -48,4 +48,17 @@ public function find(string $id): Entity\PullRequestInspection

        return $inspection;


[phpstan]

Method Regis\GithubContext\Infrastructure\Repository\DoctrinePullRequestInspections::find() should return Regis\GithubContext\Domain\Entity\PullRequestInspection but returns object.

K-Phoen · 2017-12-02T19:03:35Z

tests/unit/GithubContext/Domain/Entity/PullRequestInspectionTest.php

@@ -41,7 +41,7 @@ public function setUp()

    public function testItHasAType()
    {
-        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest);
+        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest, 4);


[phpmd]

Avoid using static access to class '\Regis\GithubContext\Domain\Entity\PullRequestInspection' in method 'testItHasAType'.

K-Phoen · 2017-12-02T19:03:36Z

tests/unit/GithubContext/Domain/Entity/PullRequestInspectionTest.php

@@ -50,14 +50,14 @@ public function testItExposesThePrNumber()
    {
        $this->pullRequest->method('getNumber')->willReturn(42);

-        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest);
+        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest, 4);


[phpmd]

Avoid using static access to class '\Regis\GithubContext\Domain\Entity\PullRequestInspection' in method 'testItExposesThePrNumber'.

K-Phoen · 2017-12-02T19:03:36Z

tests/unit/GithubContext/Domain/Entity/PullRequestInspectionTest.php


        $this->assertSame(42, $inspection->getPullRequestNumber());
    }

    public function testItIsInitializedCorrectly()
    {
-        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest);
+        $inspection = PullRequestInspection::create($this->repository, $this->pullRequest, 4);


[phpmd]

Avoid using static access to class '\Regis\GithubContext\Domain\Entity\PullRequestInspection' in method 'testItIsInitializedCorrectly'.

K-Phoen · 2017-12-02T19:13:29Z

src/BitbucketContext/Infrastructure/Repository/DoctrinePullRequestInspections.php

@@ -48,4 +48,17 @@ public function find(string $id): Entity\PullRequestInspection

        return $inspection;


[phpstan]

Method Regis\BitbucketContext\Infrastructure\Repository\DoctrinePullRequestInspections::find() should return Regis\BitbucketContext\Domain\Entity\PullRequestInspection but returns object.

K-Phoen added 3 commits December 2, 2017 17:31

Add build number to inspections

6b50bb8

Use the inspection number in the UI

3062e4e

Compute the build number when scheduling the inspection

06e4d3d

K-Phoen commented Dec 2, 2017

View reviewed changes

K-Phoen added 2 commits December 2, 2017 20:02

Update tests

f2c6db0

Fix checkstyle

2bc01c4

K-Phoen commented Dec 2, 2017

View reviewed changes

K-Phoen added 2 commits December 2, 2017 20:07

Also compute the build number for bitbucket inspections

908ad08

Ignore static access violations

abf53a8

K-Phoen commented Dec 2, 2017

View reviewed changes

K-Phoen merged commit 769302a into master Dec 2, 2017

K-Phoen deleted the inspection-number branch December 2, 2017 19:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Inspection number #60

Inspection number #60

K-Phoen commented Dec 2, 2017

K-Phoen Dec 2, 2017

K-Phoen Dec 2, 2017

K-Phoen Dec 2, 2017

K-Phoen Dec 2, 2017

K-Phoen Dec 2, 2017

K-Phoen Dec 2, 2017

		@@ -48,4 +48,17 @@ public function find(string $id): Entity\PullRequestInspection

		return $inspection;

Inspection number #60

Inspection number #60

Conversation

K-Phoen commented Dec 2, 2017

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment

K-Phoen Dec 2, 2017

Choose a reason for hiding this comment