update: CallingServiceTest.kt 수정 #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 테스트 커버리지 리포트입니다
|
TonyKim9401
approved these changes
Oct 23, 2023
| val taxiDrivers = taxiDriverRepository.findByStatus(status = TaxiDriverStatus.WAITING) | ||
| return taxiDrivers | ||
| if (taxiDrivers.isEmpty()) { throw java.lang.RuntimeException(ExceptionMessage.NO_SUCH_VALUE_EXISTS.name) } | ||
| val taxiDriver = taxiDrivers.random() |
There was a problem hiding this comment.
taxiDrivers.randon() 은 추가적으로 구현하신 확장 함수 일까요?
There was a problem hiding this comment.
리스트에서 랜덤으로 하나 가져오는 내장함수가 있어서 사용했습니다.
Comment on lines
+6
to
+9
| @Configuration | ||
| @EnableRetry | ||
| class RetryConfig { | ||
| } |
There was a problem hiding this comment.
Retry를 사용 하려면 @EnableRetry를 등록해줘야 하는군요 :)
| val taxiDrivers = taxiDriverRepository.findByStatus(status = TaxiDriverStatus.WAITING) | ||
| return taxiDrivers | ||
| if (taxiDrivers.isEmpty()) { throw java.lang.RuntimeException(ExceptionMessage.NO_SUCH_VALUE_EXISTS.name) } |
There was a problem hiding this comment.
아무래도 정상 롤백을 위해 대부분의 구간의 Exception을 RuntimeException으로 변경해야 할 듯 합니다 하하.....
나이스에요 👍
JangHyeonJun2
approved these changes
Oct 25, 2023
| @@ -195,8 +197,8 @@ class CallingServiceTest( | |||
| ) | |||
|
|
|||
| // when, then | |||
| assertThrows<IllegalArgumentException> { | |||
| callingService.assignTaxiDriver(trip) | |||
| assertThrows<RuntimeException> { | |||
There was a problem hiding this comment.
💯 테스트코드를 잘 작성하셨네요.
- 택시드라이버가 존재하지만 waiting이 없을 때
- 택시드라이버가 존재하면서 waiting이 존재하지만 일부러 오류를 내서 오류 테스트
두 가지 테스트를 더 추가하면 로직상 파악하기가 더 좋을거같아요 :)
# Conflicts: # src/main/kotlin/com/hh2/katj/trip/service/CallingService.kt # src/test/kotlin/com/hh2/katj/trip/service/CallingServiceTest.kt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
해결하려는 문제가 무엇인가요?
어떻게 해결했나요?
Attachment