Build fix for OS X 10.9 #62
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OS X 10.9 uses libc++ by default and there are several build issues with Qt 4.8.2 (and possibly later Qt 4.x versions, I haven't tested) This commit changes the C++ lib to libstdc++
|
I'm not sure about Mac but at least clang(3.4) + libc++(3.3) + Qt (4.8.5/5.1.1) has no problem on Arch Linux. (I do have problem, however, when compiling with clang(3.4) + libstdc++(gcc4.8.2) in c++0x mode). |
|
This is a Qt bug, and has been fixed in Qt already. Personally, I don't think we should do anything fancy here to work around an issue in an out-of-date Qt version. |
|
Closing. Please reopen if you think there's still a problem in up-to-date Qt versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X 10.9 uses libc++ by default and there are several build
issues with Qt 4.8.2 (and possibly later Qt 4.x versions, I haven't
tested)
This commit changes the C++ lib to libstdc++ on Mac.
I'm not sure that this is the right way to go about setting the C++ library to libstdc++ or even whether that is the right thing to do. Would it be better to require a later version of Qt with the libc++ issues fixed instead?