use direct connection to prevent a crash with sender being garbage in onSignalEmitted #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkrause
added a commit
that referenced
this pull request
Aug 12, 2014
Could be invalid already for short-lived objects in another thread. Should fix issue #89.
|
Thanks for analyzing the issue! Using a direct connection addresses the immediate problem but it will subsequently call model functions from the wrong thread. I've pushed an alternative fix that should address this issue. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running into a persistent crash as noted here: #88
Using Qt 5.2 32-bit with a 32-bit i686 injector on OS X 10.10 x86_64. Seems that onSignalEmitted's sender is garbage sometimes. Quick fix is to use a DirectConnection to invoke the method instead of an AutoConnection.
With this fix in place, I'm able to actually launch GammaRay and browse the object hierarchy of my application.