ci: Use windows-2019 instead of -latest #77
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been dealing with an issue in CI, where the test-signal test case
fails when building in Release mode on Windows.
It fails in the ConnectionEvaluator, when it tries to lock the mutex,
which is something that should simply not happen, as the shared_ptr in
the testcase keeps the ConnectionEvaluator alive at the point where the
crash occurs.
In addition, this problem is not reproducable anywhere outside Githubs
CI. If I copy the executable from Github Actions to my local machine,
it simply works.
This leads me to believe this is only a problem with this very specific
Windows environment.
By downgrading our Windows version in CI, we can avoid the problem and
at least continue development.
For context, the backtrace I was able to acquire: