Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch pre-commit to markdownlint-cli2 #33

Merged
merged 2 commits into from
Aug 27, 2024

Conversation

MiKom
Copy link
Member

@MiKom MiKom commented Aug 23, 2024

It doesn't require Ruby and works out of the box on Windows. Original markdownlint wasn't able to install Ruby properly on Windows.

Fixed a newly found issue in README as well.

@MiKom MiKom requested a review from winterz August 23, 2024 12:43
@MiKom MiKom force-pushed the precommit-switch-to-markdownlint-cli2 branch from d2eb8ff to ca08373 Compare August 23, 2024 12:51
@MiKom MiKom marked this pull request as draft August 23, 2024 13:07
It doesn't require Ruby and works out of the box on Windows. Original
markdownlint wasn't able to install Ruby properly on Windows.
As found by new markdownlint config.
@MiKom MiKom force-pushed the precommit-switch-to-markdownlint-cli2 branch from ca08373 to c7fe656 Compare August 23, 2024 13:24
@MiKom MiKom marked this pull request as ready for review August 23, 2024 13:54
@winterz winterz merged commit 8be30ff into KDAB:main Aug 27, 2024
24 checks passed
@MiKom MiKom deleted the precommit-switch-to-markdownlint-cli2 branch August 27, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants