Implement std::cmp::PartialEq for all Qt types #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like cargo fmt ruined the formatting on this one by accident.
For some types we can simply derive from PartialEq. In all other cases we piggyback on the Qt equality operator at the C++ side via a template interface. This unblocks KDAB#372
5 tasks
This avoids binding loops. Also add a new unit test to check for this behaviour. Fixes KDAB#372
ahayzen-kdab
approved these changes
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also allows us to trigger
changed()signals only when the value really changed.After this we can also implement std::cmp::PartialOrd for selected types, but it does not make sense for all types (e.g. not for
QByteArray)See #53