Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CXX errors: Expand and display span #547

Merged
merged 2 commits into from
May 26, 2023

Conversation

LeonMatthesKDAB
Copy link
Collaborator

Output:
image

This still requires upstream changes, see:
dtolnay/cxx#1214

This still requires upstream changes, see:
dtolnay/cxx#1214
@ahayzen-kdab
Copy link
Collaborator

This still requires upstream changes, see: dtolnay/cxx#1214

upstream part landed 🎉 we just need to bump the version of cxx to 1.0.95

@LeonMatthesKDAB LeonMatthesKDAB marked this pull request as ready for review May 26, 2023 09:33
@LeonMatthesKDAB
Copy link
Collaborator Author

LeonMatthesKDAB commented May 26, 2023

This still requires upstream changes, see: dtolnay/cxx#1214

upstream part landed tada we just need to bump the version of cxx to 1.0.95

Version is bumped now, PR is ready for review 🥳

Copy link
Collaborator

@ahayzen-kdab ahayzen-kdab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants