cxx-qt-gen: improve the generator / writer split #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahayzen-kdab
commented
Jul 31, 2023
This simplifies the C++ source files as they can use the helper method. This allows later for a templated signal connect that can use the public helper method to lock the QObject. Related to KDAB#577
ahayzen-kdab
force-pushed
the
577-improve-generation-writer-split
branch
from
811d0bc
to
4077398
Compare
This simplifies the writer phase of C++.
ahayzen-kdab
force-pushed
the
577-improve-generation-writer-split
branch
from
4077398
to
122bf0f
Compare
Be-ing
reviewed
Jul 31, 2023
Be-ing
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This potentially helpers later with generic signal connections.