Cxx-Qt-build: Refactor export_dir structure and introduce library Interface #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeonMatthesKDAB
changed the title
LeonMatthesKDAB
force-pushed
the
985-build-system
branch
from
9ef9be1
to
c6f661f
Compare
LeonMatthesKDAB
force-pushed
the
985-build-system
branch
4 times, most recently
from
3c1b22a
to
0dbba11
Compare
LeonMatthesKDAB
changed the title
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
ahayzen-kdab
reviewed
Jul 8, 2024
LeonMatthesKDAB
force-pushed
the
985-build-system
branch
2 times, most recently
from
23c36a2
to
fc95940
Compare
This was accidentally only running the data from the "invalid" test case, as JS was merging everything into a single object, instead of two objects in an array.
This should now be close to what we're aiming for as described in KDAB#983.
Export the build manifest from -lib instead.
This is now part of cxx-qt-lib and exported from there
This allows us to correctly order the build scripts and even pass data between build scripts. See also: https://cxx.rs/build/cargo.html#advanced-features and: https://doc.rust-lang.org/cargo/reference/build-scripts.html#the-links-manifest-key
This allows exactly specifying what to export to downstream dependencies.
Also resolve duplicate definitions and exported prefixes cleanly.
LeonMatthesKDAB
force-pushed
the
985-build-system
branch
from
fc95940
to
26df08c
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should now be close to what we're aiming for as described in #983.