Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

write integration tests #32

Closed
milianw opened this issue Feb 27, 2017 · 1 comment
Closed

write integration tests #32

milianw opened this issue Feb 27, 2017 · 1 comment
Milestone

Comments

@milianw
Copy link
Member

milianw commented Feb 27, 2017

we need to write some tests that check the integration of the perfparser utility library

@milianw milianw added this to the v1.0.0 milestone Feb 27, 2017
@milianw
Copy link
Member Author

milianw commented Mar 24, 2017

We need to do something along the following lines:

  • write a utility header that launches perf on a given debuggee. this should already have launch perf from hotspot #11 in mind so that we can reuse the same code in the future
  • write some integration tests using the existing test-clients (cpp-inlining, cpp-recursion)

the integration tests would basically boil down to:

  • run perf record on a test client in a given configuration i.e.:
  • parse the resulting perf.data file
  • verify that we get some meaningful data back, i.e.:
    • summary shouldn't be empty, potentially even compare to system values if they are easy to get. but since this can be run on many machines, don't hardcode the checks
    • do some sanity checks on the sample counts, but don't check on explicit numbers since these will fluctuate
    • do some sanity checks on the resulting top-down / bottom-up graphs. i.e. ensure that the hotspots are found and that their call graphs look same
    • also check the contents of the caller/callee results

for the model checks at the end, we may reuse parts of the code that I've written for the existing model tests

nwrogers added a commit to nwrogers/hotspot that referenced this issue Apr 11, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue Apr 11, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue Apr 11, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue Apr 26, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue May 16, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue May 16, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue May 16, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue May 17, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue Jun 13, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
nwrogers added a commit to nwrogers/hotspot that referenced this issue Jun 15, 2017
Also add supporting class for perf record so hotspot can generate
perf.data files for existing test-clients (cpp-inlining, cpp-recursion).

Fixes KDAB#32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant