Better disassembly #390

lievenhey · 2022-05-31T14:31:17Z

A rewrite of the disassembly view
closes #9

lievenhey · 2022-05-31T14:31:34Z

GitMensch · 2022-06-10T08:31:37Z

This is marvelous! I'd really like to see that integrated.
[side note: is there still a CI building AppImage anywhere? old travis is gone and the last CI release is nearly 7 months old]

milianw

please share code between the two models, maybe even extract the whole highlighting and color scheme into a shared single class and then reuse that instead of duplicating it.

src/models/codedelegate.cpp

src/models/disassemblymodel.cpp

src/models/disassemblymodel.h

src/models/disassemblyoutput.h

src/models/sourcecodemodel.cpp

src/models/sourcecodemodel.h

lievenhey · 2022-06-23T10:59:08Z

closes #9

GitMensch · 2022-06-23T11:01:45Z

closes #9

Note: for GitHub to recognize this please edit the first post and add the information there

src/models/codedelegate.cpp

src/models/disassemblymodel.cpp

src/models/disassemblyoutput.cpp

src/models/highlighter.hpp

src/models/highlighter.cpp

src/models/sourcecodemodel.cpp

tests/modeltests/tst_models.cpp

tests/modeltests/vector_static_gcc/vector_static_gcc_v9.1.0.expected.txt

CMakeLists.txt

src/models/sourcecodemodel.h

tests/modeltests/tst_models.cpp

milianw · 2022-08-28T11:08:27Z

@lievenhey moin, this is looking good and we could merge it as-is as it's an improvement.

But we definitely need to handle inlining better, see 72fec27 for some easy work from towards that direction. Could you look into improving this further based on the cpp-inlining example? Things that I'd like to see:

source listings for all files encountered in a function in a combined SourceCodeModel tree model, the file name on the first level and then second level shows source code lines like it does currently
combined source line costs when code gets inlined from somewhere, this screenshot should hopefully make this clear:

note how the code is basically all within inlined code, so currently we show 0% cost everywhere which is super misleading

this patch writes the source code in a QTextDocument and attaches a KSyntaxHighlighter to it Then it exposes the QTextLine to a custom delegate to render the colored text tst_models now requires a QCoreApplication, since QTextDocument wants to read font files

When we use disassembly on the frame for `std::__detail::_Mod<...>::__calc(...)` in `cpp-inlining` then we would get `cpp-inlining/main.cpp` as main source file, but also quite a few disassembly lines from other files that got inlined from the libstdc++ library. These then polluted the disassembly view, as it only showed the source lines from `main.cpp` and definitely doesn't have 3k lines of code. Eventually, it would be great if we could show all encountered files, in a kind of tree view instead of just skipping these source lines.

GitMensch · 2022-09-02T10:19:51Z

This is really cool! The CI builds don't provide an AppImage, do they? 'd love to test the new annotation and disassembly.

milianw · 2022-09-02T10:43:44Z

Not yet, no - I'll build one manually next week (and do a proper new release too 🤞)

But note that there's still some work left to do in the disassembly wrt inline frames

GitMensch · 2022-09-16T13:54:36Z

Just rechecking @milianw, does this mean we can expect Hotspot 1.4.0 "soonish"?

lievenhey force-pushed the better-disassembly branch from b0d7b18 to 5e68c7a Compare June 15, 2022 13:46

milianw requested changes Jun 15, 2022

View reviewed changes

lievenhey force-pushed the better-disassembly branch 3 times, most recently from b7f7137 to 7c7a861 Compare June 23, 2022 10:58

lievenhey force-pushed the better-disassembly branch 2 times, most recently from 7d426d8 to 2b6edde Compare June 23, 2022 12:19

milianw requested changes Jun 23, 2022

View reviewed changes

lievenhey force-pushed the better-disassembly branch 7 times, most recently from 45e078e to 4c406f3 Compare June 29, 2022 11:30

milianw requested changes Jun 29, 2022

View reviewed changes

lievenhey force-pushed the better-disassembly branch 10 times, most recently from 99d0c44 to b7536d4 Compare June 30, 2022 11:08

lievenhey force-pushed the better-disassembly branch from b7536d4 to 3d20c66 Compare June 30, 2022 13:29

lievenhey requested a review from milianw July 5, 2022 09:48

milianw force-pushed the better-disassembly branch from 3d20c66 to 72fec27 Compare August 28, 2022 11:04

milianw approved these changes Aug 28, 2022

View reviewed changes

lievenhey and others added 4 commits August 30, 2022 09:55

add source code view

62dbd15

sum assembly costs and show them in the source code

4c1bc0a

add syntax highlighting

ab513d7

this patch writes the source code in a QTextDocument and attaches a KSyntaxHighlighter to it Then it exposes the QTextLine to a custom delegate to render the colored text tst_models now requires a QCoreApplication, since QTextDocument wants to read font files

lievenhey force-pushed the better-disassembly branch from 72fec27 to 88e29ae Compare August 30, 2022 07:56

milianw merged commit f578fc2 into master Sep 2, 2022

milianw deleted the better-disassembly branch September 2, 2022 09:53

GitMensch mentioned this pull request Nov 3, 2022

"Continuous build" on Github Releases seems to be outdated. #397

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Better disassembly #390

Better disassembly #390

lievenhey commented May 31, 2022 •

edited

Loading

lievenhey commented May 31, 2022

GitMensch commented Jun 10, 2022

milianw left a comment

lievenhey commented Jun 23, 2022

GitMensch commented Jun 23, 2022

milianw commented Aug 28, 2022

GitMensch commented Sep 2, 2022

milianw commented Sep 2, 2022 •

edited

Loading

GitMensch commented Sep 16, 2022

Better disassembly #390

Better disassembly #390

Conversation

lievenhey commented May 31, 2022 • edited Loading

lievenhey commented May 31, 2022

GitMensch commented Jun 10, 2022

milianw left a comment

Choose a reason for hiding this comment

lievenhey commented Jun 23, 2022

GitMensch commented Jun 23, 2022

milianw commented Aug 28, 2022

GitMensch commented Sep 2, 2022

milianw commented Sep 2, 2022 • edited Loading

GitMensch commented Sep 16, 2022

lievenhey commented May 31, 2022 •

edited

Loading

milianw commented Sep 2, 2022 •

edited

Loading