implementation of WH(tautau) analysis #216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harrypuuter
suggested changes
Apr 27, 2023
src/lorentzvectors.cxx
Outdated
| return ROOT::Math::PtEtaPhiEVector(default_float,default_float,default_float, | ||
| default_float);; | ||
| auto dileptonsystem = p4_1 + p4_2; | ||
| auto dileptonsystem_scaled = 0.47*dileptonsystem; |
There was a problem hiding this comment.
why not use a more generic implementation, where you can configure this correction factor ? From what I see, the lt and tt functions are identical apart from the 0.47 and the 0.69
src/quantities.cxx
Outdated
| /// | ||
| /// \returns a dataframe with the new column | ||
|
|
||
| ROOT::RDF::RNode Lt(ROOT::RDF::RNode df, const std::string &outputname, |
There was a problem hiding this comment.
choose a more descriptive name like sum_pts()
src/quantities.cxx
Outdated
| /// | ||
| /// \returns a dataframe with the new column | ||
|
|
||
| ROOT::RDF::RNode eta_vis(ROOT::RDF::RNode df, const std::string &outputname, |
There was a problem hiding this comment.
a more descriptive name, maybe pair_eta ?
There was a problem hiding this comment.
I think it is more consistent to use eta_vis and phi_vis, since we have also m_vis and pt_vis
src/quantities.cxx
Outdated
| /// | ||
| /// \returns a dataframe with the new column | ||
|
|
||
| ROOT::RDF::RNode phi_vis(ROOT::RDF::RNode df, const std::string &outputname, |
add generic implementation to combine an arbitrary number of 4 vectors
harrypuuter
suggested changes
Apr 28, 2023
src/lorentzvectors.cxx
Outdated
| const ROOT::Math::PtEtaPhiMVector &p4_2) { | ||
| if (p4_1.pt() < 0.0 || p4_2.pt() < 0.0) | ||
| return ROOT::Math::PtEtaPhiEVector(default_float,default_float,default_float, | ||
| [p4_miss_sf](const ROOT::Math::PtEtaPhiMVector &p4_23) { |
There was a problem hiding this comment.
use general names here: scale and p4 should be fine
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.