Add working Onnxruntime Producer #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshadskiy
reviewed
Mar 7, 2024
nshadskiy
reviewed
Mar 7, 2024
nshadskiy
reviewed
Mar 7, 2024
include/ml.hxx
Outdated
| throw std::runtime_error("Number of input parameters does not match"); | ||
| } | ||
|
|
||
| std::string replace_str = std::string("EVTID"); |
There was a problem hiding this comment.
Maybe add a comment here that this is only needed if an even/odd splitting used.
There was a problem hiding this comment.
Your right, in the generic version, this is not required
nshadskiy
reviewed
Mar 7, 2024
include/ml.hxx
Outdated
| ->debug("Inference time: {} mus", timer.RealTime() * 1000 * 1000); | ||
| return output; | ||
| }; | ||
| auto df3 = df2.Define(outputname, |
There was a problem hiding this comment.
I don't see any definition of df2, is that correct?
There was a problem hiding this comment.
It should be
df1 = df.Define(outputname,
nshadskiy
reviewed
Mar 7, 2024
Comment on lines
27
to
28
| // std::unique_ptr<Ort::Session> session_ptr(session); | ||
| // sessions_map[modelPath] = std::move(session_ptr); |
There was a problem hiding this comment.
Commented line can be dropped, I guess.
nshadskiy
reviewed
Mar 7, 2024
nshadskiy
reviewed
Mar 7, 2024
src/utility/OnnxSessionManager.cxx
Outdated
| size_t inputTensorSize = vectorProduct(input_node_dims); | ||
| size_t outputTensorSize = vectorProduct(output_node_dims); | ||
|
|
||
| // outputTensorSize = 8; |
harrypuuter
force-pushed
the
cmake_restructure
branch
from
b7f730a
to
726d13d
Compare
nshadskiy
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a generic implementation of an OnnxRuntimeProducer