Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated tools/environment to build on macOS Mojave #180

Merged
merged 2 commits into from
Oct 7, 2018

Conversation

Kazzz-S
Copy link
Contributor

@Kazzz-S Kazzz-S commented Oct 7, 2018

@klayoutmatthias

Attempted to build KLayout on macOS 10.14 Mojave. It was bit painful.
For the time being, it would be better not to build on Mojave since "ruby.h" is not included in the OS.
Please refer to Kazzz-S#29

Fortunately, binary package built on HighSierra works on Mojave, too (#160).

Regards,
Kazzz

@thomaslima
Copy link
Collaborator

Hello @Kazzz-S . I am confused, does the build work in Mojave or not?

I have found a typo in the image you compiled: it says "Ysemite" instead of "Yosemite".

Another question I have is what is the purpose of the scripts KlayoutEditor.sh and KlayoutViewer.sh? People I know have been confused by it and preferred to use the normal Klayout.app bundle, then set it to editor or viewer mode. Besides, I have changed the bundle so that "open with" works with the bundle klayout.app, and set the extension .gds, .gds2 and .oas to Klayout (see Info.plist), which wouldn't if the default app was one of the scripts.

@klayoutmatthias klayoutmatthias merged commit 91d9d9a into KLayout:master Oct 7, 2018
@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Oct 7, 2018

Hello @thomaslima,

Thank you for pointing out the typo. I'll fix it soon.


I am confused, does the build work in Mojave or not?

I've found "ruby.h" is not included in the current 10.14 macOS.
Therefore build "using OS bundled Ruby as is" fails.
With some workaround (Kazzz-S#29), I could build in Mojave, too.
So far, the major build problem in Mojave is "missing ruby.h". I hope the next OS release will fix this.
I have not tried other choices (e.g. Ruby from Homebrew).


Another question I have is what is the purpose of the scripts KlayoutEditor.sh and KlayoutViewer.sh?

There is a little historical reason.
Earlier (even now?), Windows binary package provided two types of launching icons; one for Editor and another for Viewer. I liked this idea.
In my main work environment (Linux), I've prepared two icons each of which is passed different "-style" option to Qt. More precisely, with Qt4, I'm using "plastique" for Editor; "motif" for Viewer.

I wanted to mimic this in Mac, too, several years ago. No change, since then.
If Mac users do not need this (even optionally), we can drop this in future.

Regards,
Kazzz

@thomaslima
Copy link
Collaborator

Thanks for the explanation!

Best,
Thomas

@lukasc-ubc
Copy link

lukasc-ubc commented Oct 8, 2018 via email

@Kazzz-S
Copy link
Contributor Author

Kazzz-S commented Oct 8, 2018

2018-10-08 19 58 11

How about this? Sorry for not being a good designer!
Kazzz

@thomaslima
Copy link
Collaborator

thomaslima commented Oct 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants