-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thank you *so* much for this #26
Comments
Hi. Glad you liked it! |
@andstor Yeah well I'm really hoping I can contribute at some point! One thing I just realized: I had thought that greek symbols and constants like e would be converted to their maxima equivalent (e.g. pi -> %pi), but that doesn't seem to be the case. How do you handle this situation on your end? Is this something I could submit a PR for? |
@mattvague Thanks for pointing that out. The library is mainly created with the intend of integrating MathQuill into STACK (WIP). STACK doesn't need the % sign prepended (handled server side), so this problem has passed me by. However, we would of course correct this, adding the % sign for the required constants, as this is the expected Maxiama behaviour. I have created an issue #27. I would be more than happy for a PR correcting this 😃 |
Cool! Yeah it’d be nice if it conformed to standard maxima. I just realized
though that it’s a super easy fix on the maxima side so in the interest of
time I’ll do that for now and circle back on this
…On Fri, Feb 1, 2019 at 1:26 PM André Storhaug ***@***.***> wrote:
@mattvague <https://github.com/mattvague> Yes, thanks for pointing that
out. The library is mainly created with the intend of integrating
MathQuill <http://mathquill.com> into STACK
<https://moodle.org/plugins/qtype_stack> (WIP). STACK doesn't need the %
sign prepended (handled server side), so this problem has passed me by.
However, we would of course correct this, adding the % sign for the
required constants, as this is the expected Maxiama behaviour. I have
created an issue #27 <#27>. I
would be more than happy for a PR correcting this 😃
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#26 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD92RvCN6TvfHuh5UQCu0Hz8Ve7NyiHks5vJIbWgaJpZM4acNgo>
.
|
Feel free to close or delete this issue, but I just wanted to say thank you for this library! Just saved me many hours of doing this myself. Let me know if there's anything I can do to help with the project.
The text was updated successfully, but these errors were encountered: