Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thank you *so* much for this #26

Open
mattvague opened this issue Jan 31, 2019 · 4 comments
Open

Thank you *so* much for this #26

mattvague opened this issue Jan 31, 2019 · 4 comments

Comments

@mattvague
Copy link

Feel free to close or delete this issue, but I just wanted to say thank you for this library! Just saved me many hours of doing this myself. Let me know if there's anything I can do to help with the project.

@andstor
Copy link
Member

andstor commented Jan 31, 2019

Hi. Glad you liked it!
A lot of work has been put down in this library, so feedback is much appreciated.
Please let me know if you encounter any problems.

@mattvague
Copy link
Author

mattvague commented Feb 1, 2019

@andstor Yeah well I'm really hoping I can contribute at some point! One thing I just realized: I had thought that greek symbols and constants like e would be converted to their maxima equivalent (e.g. pi -> %pi), but that doesn't seem to be the case. How do you handle this situation on your end? Is this something I could submit a PR for?

@andstor
Copy link
Member

andstor commented Feb 1, 2019

@mattvague Thanks for pointing that out. The library is mainly created with the intend of integrating MathQuill into STACK (WIP). STACK doesn't need the % sign prepended (handled server side), so this problem has passed me by. However, we would of course correct this, adding the % sign for the required constants, as this is the expected Maxiama behaviour. I have created an issue #27. I would be more than happy for a PR correcting this 😃

@mattvague
Copy link
Author

mattvague commented Feb 1, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants