Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Spotube to Homebrew #120

Open
eriktiekstra opened this issue Jun 22, 2022 · 23 comments
Open

Add Spotube to Homebrew #120

eriktiekstra opened this issue Jun 22, 2022 · 23 comments
Labels
enhancement New feature or request macOS macOS related issue

Comments

@eriktiekstra
Copy link

Is your feature request related to a problem? Please describe.
Installation of Spotube on a Mac currently only is available by downloading the dmg from Github. It would be great to be able to use a package-manager (Homebrew) for this.

Describe the solution you'd like
Add Spotube to Homebrew casks

Describe alternatives you've considered
N/A

Additional context
N/A

@eriktiekstra eriktiekstra added the enhancement New feature or request label Jun 22, 2022
@KRTirtho
Copy link
Owner

Literally have no idea about homebrew although have heard sometimes about it. Never been a user in the Apple Garden at all. So its kind of hard for me to deal with this. Also I don't own a Mac. So, kind of impossible I think since Apple has their so called "policy" of not even letting developers develop applications for their Platform without buying their products

I guess, it'd more viable if someone who owns a Mac maintains & publishes the homebrew stuff on behalf of this project

@RaptaG RaptaG added macOS macOS related issue and removed good first issue labels Mar 8, 2023
@kiblik
Copy link

kiblik commented Apr 23, 2023

Hi there,

I wanted to add Spotube to Homebrew: Homebrew/homebrew-cask#145688
Unfortunately, the audit doesn't pass because of a missing signature. Is it possible to fix it?

audit for spotube: failed
 - Signature verification failed:
/private/tmp/d20230423-3158-rup9bx/spotube.app: rejected

macOS on ARM requires software to be signed.
Please contact the upstream developer to let them know they should sign and notarize their software.
Error: 1 problem in 1 cask detected

@KRTirtho
Copy link
Owner

Spotube macos is certainly missing signing. I'm unable to do that as it requirese access to XCode to generate certificates for the app

@kiblik
Copy link

kiblik commented Apr 24, 2023

Spotube macos is certainly missing signing. I'm unable to do that as it requirese access to XCode to generate certificates for the app

I have no experience with MacOS development but I suppose it should be possible to handle it in Github Action somehow, shouldn't it?
It would also increase credibility of the whole Spotube in general.

https://docs.github.com/en/actions/deployment/deploying-xcode-applications/installing-an-apple-certificate-on-macos-runners-for-xcode-development

@razvanazamfirei
Copy link

Signing would still require a certificate.

@KRTirtho
Copy link
Owner

And I can't issue a certificate without mac :'(

@kiblik
Copy link

kiblik commented Apr 26, 2023

And I can't issue a certificate without mac :'(

I might help in this step :) I will look at it

@JounQin
Copy link

JounQin commented Jan 4, 2024

I've just added it into my tap https://github.com/homebrew-x/homebrew-x

Usage

brew install homebrew-x/x/spotube

JounQin added a commit to JounQin/spotube that referenced this issue Jan 4, 2024
@martin-braun
Copy link

@JounQin Thanks for taking action, although instead of making your own tap, it would be so much better if the signing issue could be solved.

@KRTirtho Who's building the binary and adding that to Github? The same person / process can sign the app for you.

@JounQin
Copy link

JounQin commented Jan 4, 2024

it would be so much better if the signing issue could be solved.

Sure, but custom tap is much better for such non signed apps.

@KRTirtho can also host it as https://github.com/KRTirtho/homebrew-spotube for example, no signing required at all.

@gatspy
Copy link

gatspy commented Jan 12, 2024

Looking forward to homebrew's release

@JounQin
Copy link

JounQin commented Jan 12, 2024

Such comments do not help anything.

@gmcinalli
Copy link

Here's an example of a Homebrew Cask tap hosted on GitHub.

https://github.com/th-ch/homebrew-youtube-music

@JounQin
Copy link

JounQin commented Jan 16, 2024

@gmcinalli Didn't you see #120 (comment)?

@gmcinalli
Copy link

gmcinalli commented Jan 16, 2024

@JounQin Yes, sorry. Just wanted to help understand better with a very similar project.

@Kairixir
Copy link

Kairixir commented Feb 29, 2024

I might help in this step :) I will look at it
> [Feature] Install with brew #409

Sadly this is a Catch 22. Only someone @KRTirtho trusts should create the certificate so the private key stays secret. At the same time @KRTirtho does not have Mac.

The only solution I see is either: @KRTirtho adds a person he trusts to the project so they create the certificate for this app, or @KRTirtho gets his hands on some Mac.

btw. I found an article showing how to automate the signing process using GitHub Actions


@KRTirtho can also host it as https://github.com/KRTirtho/homebrew-spotube for example, no signing required at all.
#120 (comment)

Sounds like the best option to me, unless the certificate is created.
btw. Thank you, @JounQin, for the Tap you've created.

@Kairixir
Copy link

After re-reading the README.md — maybe @karniv00l can help?

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 3, 2024

@Kairixir don't worry pal. I can now create one since I've recently got a mac. I'll try to add it to homebrew and even get it notarized by Apple. I was just learning the new mac ecosystem for the past month. Otherwise, 3.4.1 would've been in homebrew 😄

TBH the new keyboard layout, it's killing me lol 🤣

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 5, 2024

Well I tried to create a Developer ID but unfortunately, Apple doesn't accept Bangladeshi developer account applications
https://forums.developer.apple.com/forums/thread/127494
https://discussions.apple.com/thread/255363512

So I temporarily created a tap repository and everyone should be able to use it to install spotube through homebrew

$ brew tap krtirtho/apps
$ brew install --cask spotube

@KRTirtho
Copy link
Owner

KRTirtho commented Mar 5, 2024

I'll update the README too

@AITleo
Copy link

AITleo commented Apr 16, 2024

This issue can be closed, right?

https://github.com/KRTirtho/spotube/blob/master/README.md?plain=1#L137

@binaryben
Copy link

This issue can be closed, right?

Depends. Might still be open to track not needing a custom tap or other things

@shishkin
Copy link

shishkin commented Oct 2, 2024

I've just noticed that 3.8.2 is out for 2 days, but the cask hasn't been updated since 2 weeks. Maybe some automation via GitHub Actions is needed to make sure the cask stays fresh?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request macOS macOS related issue
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.