Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support path stripping on install. #260

Closed
pjf opened this issue Nov 4, 2014 · 2 comments
Closed

Support path stripping on install. #260

pjf opened this issue Nov 4, 2014 · 2 comments
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec

Comments

@pjf
Copy link
Member

pjf commented Nov 4, 2014

Often we end up with install stanzas which look like this:

{
    "file"       : "MyMod-1.1.1/MyMod",
    "install_to" : "GameData"
}

This currently makes GameData/MyMod-1.1.1/MyMod, when we want it to create GameData/MyMod.

Paths which already contain GameData in them are handled by our current code, but it would be good to provide an explicit strip section which indicates what should be stripped off when installing:

{
    "file"       : "MyMod-1.1.1/MyMod",
    "install_to" : "GameData",
    "strip"      : "MyMod-1.1.1"
}

This would also assist in #259.

@pjf pjf added Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec ★★☆ labels Nov 4, 2014
@pjf
Copy link
Member Author

pjf commented Nov 8, 2014

As invultri pointed out on IRC, is there any issue if we just strip out everything up until the last segment of the path?

@pjf
Copy link
Member Author

pjf commented Nov 9, 2014

As of PR #287, we now do path stripping automatically. So unless I'm mistaken, this is done. :)

(Checking with @christianvdstap just in case.. please re-open if I'm wrong here!)

@pjf pjf closed this as completed Nov 9, 2014
@pjf pjf removed the ★★☆ label Nov 9, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core (ckan.dll) Issues affecting the core part of CKAN Spec Issues affecting the spec
Projects
None yet
Development

No branches or pull requests

1 participant