Adds KerbalKonstructs #27
Conversation
|
Go ahead. :) |
|
Thank you! I'd wait before merging this one until we hear from the author of KerbinSide (I'm about to open that one too) to check if the installation path is a problem or not. |
|
The installation path should be fine for both. The only potential issue is that KerbalKonstructs is usually in GameData/medsouz/KerbalKonstructs (I'm planning to take out the medsouz directory anyway) and is packaged with KerbinSide like that so it might cause a conflict. Poking @AlphaAsh |
|
That's not an issue, CKAN just ignores the version packaged with KerbinSide :) |
|
Okay I just tried installing KerbinSide. It "mostly" works, but I get a missing texture on the app button, plus a nice and long stream of NREs during flight. I guess this is staying open until we hear from @AlphaAsh :) |
|
Okay turns out I lied, it won't work unless its in GameData/medsouz/KerbalKonstructs. I forgot I hard coded image paths. |
|
Okay, no problem :) Unfortunately I can't figure out how to put it in the right directory, so we are going to need for @pjf to help us out I think. |
|
Yeah the pathing in KK is mostly hard-coded. If it needs changing, go ahead. I can update KerbinSide's KK easily enough. |
|
Thank you AlphaAsh, but I'd really just wait to hear pjf on this one: one of the main points of CKAN is not forcing you to change your packaging, so even if you are available to do that, it would be really better not :) |
|
KerbinSide can't be the only mod that already includes a dependency in the package so yeah, it'd probably be sensible for CKAN to be able to handle multiple mods in a single package. EDIT - MM shows up in every other mod package, for example :D |
|
Actually it already does, and very nicely :) It doesn't take KK from your zip, it actually downloads another fresh copy and installs that one. The real problem here is that CKAN insists on putting KerbalKonstructs in instead of the path it's expecting. I'm not familiar enough with how CKAN resolves the paths in the install stanzas, I hoped it was just a matter of saying but apparently that's not the way to do it, because it doesn't work :/ |
|
Ah, I getcha. Yeah, you're right that needs looking at on CKAN's side if it's to stay true to its mission statement of not forcing changes on packaging. Like you said. Thanks for the clarification. |
|
Oh and thank you Ippo for getting KK and KerbinSide sorted with this. I've only just read up on CKAN and really appreciate you doing it. Saves me a job and I'd probably have forgotten by the time I wake up tomorrow :P |
|
No problem, we'll keep you up to date :) |
|
KSP-CKAN/CKAN#315 may be required if we need to specify an output folder. Let me bump up the priority on that ticket. |
|
So, I tried modifying the netkan file. As I understand it, the new install stanza I added should work, but it doesn't. NetKAN validates the file with no problem and creates the CKAN file, but then I get a BadInstallLocationKraken when I try to install that file, and I really don't understand why. I must be missing something really obvious, I'm sure... |
|
Is there a reliance on KK being catalogued as well? Otherwise no other ideas here. I may code but CKAN is magic compared to the stuff I can do. |
|
@Ippo343 are you sure you're running the CKAN version with the install_to changes - KSP-CKAN/CKAN#394 ? |
|
@AlexanderDzhoganov: I am not. But I shouldn't need to, because this is a normal install stanza: |
|
This issue has bothered me for days. I really have no idea why things were failing last week, but I have just finished testing this using the Protium release and it works fine without changes. |
|
Awwww yisss! :D Travis didn't like it that I pulled the license from KS. Now it's good :) |
Adds KerbalKonstructs
Adds KerbalKonstructs
Blocked on KSP-CKAN/CKAN#315
If @medsouz is okay with it, I'd like to add KerbalKonstructs to the CKAN.
This file installs the mod into GameData/KerbalKonstructs: @medsouz, is it ok?
File validated and tested (aside from the issue about whether the path is correct).