Fix keyword lexing. Resolves #900 #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 27, 2015
|
Should we be changing this in TinyPG? is this just a stopgap? |
|
I don't want to touch tinyPG code if I don't have to. This is too complex a feature to quickly fix. It would be a rabbit hole I'd be stuck in a long time to try to work out the logic of what its lexxer is doing. I think this is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't know why TinyPG doesn't take the longest possible regex match and instead picks a shorter token when available, but at any rate I fixed it by using the regex special term "\b" to indicate a word boundary, putting it around all the keywords like 'not'.
So, for example,
laforgewon't be taken as the keywordforbecause it's now defined as\bfor\b.