Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KSPe.InstallChecker is not being able to show its Modals #54

Closed
Lisias opened this issue May 13, 2023 · 3 comments
Closed

KSPe.InstallChecker is not being able to show its Modals #54

Lisias opened this issue May 13, 2023 · 3 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@Lisias
Copy link
Collaborator

Lisias commented May 13, 2023

The KSPe.InstallChecker is not being able to communicate to the user the need to restart the system because 000_KSPe is freaking out when it can't handle the new auxiliary DLLs in the PluginData.

The solution is to instrument KSPe to do not emit Modal Windows when:

  • KSPe.InstallChecker is present
  • There're more than one copy of KSPe Assembly on memory.

As this is a situation where InstallChecker will need the Modal to talk to the user.

@Lisias Lisias added the bug Something isn't working label May 13, 2023
@Lisias Lisias added this to the 2.5.2.1 milestone May 13, 2023
@Lisias Lisias self-assigned this May 13, 2023
Lisias added a commit that referenced this issue May 13, 2023
@Lisias
Copy link
Collaborator Author

Lisias commented May 13, 2023

This fix is mandatory for CurseForge users, otherwise future KSPe updates will be troublesome for them.

Everybody else should not be affected.

@Lisias
Copy link
Collaborator Author

Lisias commented May 13, 2023

Fixed on commit 991e2e4 .

@Lisias Lisias closed this as completed May 13, 2023
@Lisias
Copy link
Collaborator Author

Lisias commented May 14, 2023

The code for this issue was rolled back, this code will not reach the mainstream.

Issue #50 solves the problem in a better way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant