Fix cfg syntax errors #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Capkirk123
added a commit
to Capkirk123/ROCapsules
that referenced
this pull request
May 27, 2022
* Add Apollo D2 GE Capsule * Fix Antenna Drag Cube Issue (Hopefully) * Remove HeatShield Temp Values * Who the hell still uses RemoteTech. * Format into Tabs * Fix RCS Thrusters * Remove Non Needed Fx * Fix Antenna Animation * Removed GE AJ model and copied the ROEngines Part * update README.md * Fixed & Readded the AJ10 model * Update README.md * Fixed Hopefully All issues & added a MM Section to remove if CH-4 Is installed * Fix Realplume Configs * Fix Parachute Temps * Fix Patches * Revamp CH-4 Patch, Fix Any Load issues in 1.11 * Fix Formatting * Add Apollo D-2 (GE Apollo proposal) by mcd0uble (KSP-RO#88) * Add Apollo D2 GE Capsule * Fix Antenna Drag Cube Issue (Hopefully) * Remove HeatShield Temp Values * Who the hell still uses RemoteTech. * Format into Tabs * Fix RCS Thrusters * Remove Non Needed Fx * Fix Antenna Animation * Removed GE AJ model and copied the ROEngines Part * update README.md * Fixed & Readded the AJ10 model * Update README.md * Fixed Hopefully All issues & added a MM Section to remove if CH-4 Is installed * Fix Realplume Configs * Fix Parachute Temps * Fix Patches * Revamp CH-4 Patch, Fix Any Load issues in 1.11 * Fix Formatting * Minor fixes to D2 * Fix RCS thruster power and RCS block mass * D-2 solar panels are explicitly non-tracking but are set to tracking in RO SolarConfig block. * Fix D2 DM antenna--it's a DM (CM) antenna, not the HGA on the SM. It should not be S-band etc. * Decrease D2 DM mass to account for Ablator Co-authored-by: Majorvader111 <comeon92rules@gmail.com> * Scale up D2 solar panels by 1.5x to provide more power. Probably still not enough? * Add Waterfall support for all parts. (KSP-RO#84) * Add Waterfall support for all parts. * Update RCS thrusters to use new plumes. * Waterfall: Remove extraneous :NEEDS[SmokeScreen] * Waterfall: Update to reflect breaking change in ROWaterfall. Now handwritten modules must be added in `:AFTER[ROWaterfall]`. * Add Missing WaterFall Configs. Formatting Fixes. Add Nathans Fixes. * Hopefully Fix Thrust Transform Issues * Should Be Fixed Now * D2 fixes from @vader111 - fixed AJ10-133 model, fixed using % operator in new modules, removed extraneous NEEDS, fixed skrit RCS power, Waterfall configs for AJ10-133, fixed TACLS volume. * More D-2 tweaks: Lower DM mass further to aim for 2.8t total for DM (+ chute); that is a cool 700kg over (1.333x) the original GE spec, but weight growth that affected Apollo doubtless would have bit here too. Fix MMs to carry Nitrogen for Kerbal EVAs. Hopefully fix Skirt nodes not doing things in symmetry. * Convert textures to DDS (KSP-RO#89) * Fix Mission Module Ladder & Airlock Colliders * Fix Waterfall Rcs Sounds & Effects and Fix Engine Glow Clipping * Fix Solar Panel Sun catcher Transform * [D2] Let's make us survive a lunar reentry, shall we? And have a reasonable AoA doing so. * D2 Block II LES: use the same resource in PROPELLANT node as in ModuleFuelTanks >.> * Hopefully Fix D2 Mission Module Ladder Colliders * D2: Use probe and drogue from original version of Alternate Apollo; the v2 ones are busted. * D2: Fix AJ10-133 not being able to attach to nodes in 4x. * D2: Revert to original mission module models since at least on those kerbals don't get knocked off the ladder on spawn. * copypasta * Convert D-2 LES from HTPB to PBAN (it is maybe supposed to be double-base, who knows.) * Switch over to the new HS presets, Remove part values that the preset will override anyway * A few more capsule fixes, and fix D-2 to use EarlyLunar. * Increase ablator on Vostok/Voskhod. * Prep for v1.4 * Create makeMeta.py * initial setup of release CI script * Started working on adding TU Recoloring support to Gemini * Waterfall: less obnoxious audio template for the Gemini OAMS engine * Fix Apollo CM and HS thermal stats so it is reenterable again. * Add pressurant to engines/RCS and tanks @Capkirk123. Also correct Apollo RCS to use NTO/MMH as it is supposed to, not NTO/AZ50. * Prep for v1.5 * Add helium * Deprectate deprecated antenna. * Up ablator on Vostok/Voskhod to 450 units, fix mass. * Revise diameter (and mass) of D-2 HGA. Close KSP-RO#97 * Fix Vostok, Voskhod masses. * Fix typo in comment * Tweak Gemini lunar HS * Fix too-low LH2 and LOX on Gemini Equipment Section. Technically the batteries would have been swapped out for LH2 and LOX but we don't really have tank configs we can do that with. * Fix GeminiOAMS RCS alignment Engine models reused as RCS need useZaxis = True in moduleRCSFX * Mark B9PS as a dependency on CKAN The new BDB parts (Gemini, Mercury) use it. * Star-13E (Gemini Retro) should probably be CTPB. * Fix insufficient LH2 reserves on Gemini equipment section * Fix typo in Apollo SM Helium amount * Tweak GeminiBDB IVA Pilots were floating off their seat, heads were poking out of the capsule, and interior point of view was too high for both seeing out and looking a controls * Fix ROLib link in readme * Prep for v1.5.3 * Do not remove the apollo D2 if CH4 is installed * Revise dynasoar thermals to realistic values (KSP-RO#107) * Add missing `ignoreForIsp` for helium * Fix AcquireRange to make undocking possible * Fix AcquireRange to make undocking possible * Fix typo in description of Gemini retro (KSP-RO#112) * Replace Dynasoar with X-20 Moroz Dynasoar (KSP-RO#110) * Add Moroz Dynasoar * Update README.md * Deprecate uneeded old Dyna Parts * WF for new Dynasoar Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com> * Fix transparent hole on Gemini OAMS thrusters Now that DepthMask is on CKAN, we can depend it. * Fix KSP-RO#101 * Fix up CKAN dependencies * Fix .cfg typos fuelCrossFeed, skinMaxTemp, childStageOffset * Fix Missing DRE Needs * Fix .cfg typo * Add pressurefed tag to OAMS (KSP-RO#113) Add pressure fed tag to OAMS thrusters * Remove deprecated FASA Mercury and Gemini parts (KSP-RO#109) * Update script for KSP 1.12 * Manually update the .version file since Actions doesn't handle it for this repo * Add the Zenit camera system (KSP-RO#114) * Add 4kL fuel tank to D-2 1-engine Skirt Section (KSP-RO#115) Visually the 1-engine and 4-engine skirts have spherical fuel tanks of the same size but the 1-engine skirt was lacking the fuel tank config. * Untabify version file * Release prep * Fix cfg syntax errors (KSP-RO#118) * Fix :FOR[RealismOverhaul] in ROCapsules (KSP-RO#119) * Pretty-print the .version file * Add MM syntax validation action * Add Alternative Dynasoar cockpit (KSP-RO#121) Add alternative dynasoar cockpit with rounded nose * Update capsule thermals (KSP-RO#122) * Update capsule thermals Update capsule thermal properties, and patch maxtemps after RO global patches run. Everything now works mostly correctly, except for: Gemini needs inflated skinMaxTemp due to receiving excessive convective flux. Drag cube issue? Orion HS does not occlude Orion CM, which consequently cannot properly survive reentry. Drag cube issue. * Correct MM patching order, missing newlines * Missed one * Remove DRE patches Remove fancy DRE patches, they apparently get clobbered by a later RO pass anyway. Co-authored-by: Majorvader111 <comeon92rules@gmail.com> Co-authored-by: NathanKell <nathankell@gmail.com> Co-authored-by: Alvin Meng <35266431+al2me6@users.noreply.github.com> Co-authored-by: siimav <siim.aaver@gmail.com> Co-authored-by: jwvanderbeck <jwvanderbeck@gmail.com> Co-authored-by: Dan <papwr17@gmail.com> Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com> Co-authored-by: Degenerate Ground State <DegenerateGroundState@users.noreply.github.com> Co-authored-by: Stonesmile <62522391+StonesmileGit@users.noreply.github.com> Co-authored-by: LPG <lpgagnon@gmail.com> Co-authored-by: Ben <kalynndarcy@gmail.com> Co-authored-by: ZombieZilla <48612811+ZombieZilla@users.noreply.github.com> Co-authored-by: DRVeyl <DRVeyl@gmail.com> Co-authored-by: Arrowmaster <arrow@arrowmaster.net> Co-authored-by: HebaruSan <HebaruSan@users.noreply.github.com>
NathanKell
added a commit
that referenced
this pull request
Jun 14, 2022
* Mercury Weight adjust * Update to master (#1) * Add Apollo D2 GE Capsule * Fix Antenna Drag Cube Issue (Hopefully) * Remove HeatShield Temp Values * Who the hell still uses RemoteTech. * Format into Tabs * Fix RCS Thrusters * Remove Non Needed Fx * Fix Antenna Animation * Removed GE AJ model and copied the ROEngines Part * update README.md * Fixed & Readded the AJ10 model * Update README.md * Fixed Hopefully All issues & added a MM Section to remove if CH-4 Is installed * Fix Realplume Configs * Fix Parachute Temps * Fix Patches * Revamp CH-4 Patch, Fix Any Load issues in 1.11 * Fix Formatting * Add Apollo D-2 (GE Apollo proposal) by mcd0uble (#88) * Add Apollo D2 GE Capsule * Fix Antenna Drag Cube Issue (Hopefully) * Remove HeatShield Temp Values * Who the hell still uses RemoteTech. * Format into Tabs * Fix RCS Thrusters * Remove Non Needed Fx * Fix Antenna Animation * Removed GE AJ model and copied the ROEngines Part * update README.md * Fixed & Readded the AJ10 model * Update README.md * Fixed Hopefully All issues & added a MM Section to remove if CH-4 Is installed * Fix Realplume Configs * Fix Parachute Temps * Fix Patches * Revamp CH-4 Patch, Fix Any Load issues in 1.11 * Fix Formatting * Minor fixes to D2 * Fix RCS thruster power and RCS block mass * D-2 solar panels are explicitly non-tracking but are set to tracking in RO SolarConfig block. * Fix D2 DM antenna--it's a DM (CM) antenna, not the HGA on the SM. It should not be S-band etc. * Decrease D2 DM mass to account for Ablator Co-authored-by: Majorvader111 <comeon92rules@gmail.com> * Scale up D2 solar panels by 1.5x to provide more power. Probably still not enough? * Add Waterfall support for all parts. (#84) * Add Waterfall support for all parts. * Update RCS thrusters to use new plumes. * Waterfall: Remove extraneous :NEEDS[SmokeScreen] * Waterfall: Update to reflect breaking change in ROWaterfall. Now handwritten modules must be added in `:AFTER[ROWaterfall]`. * Add Missing WaterFall Configs. Formatting Fixes. Add Nathans Fixes. * Hopefully Fix Thrust Transform Issues * Should Be Fixed Now * D2 fixes from @vader111 - fixed AJ10-133 model, fixed using % operator in new modules, removed extraneous NEEDS, fixed skrit RCS power, Waterfall configs for AJ10-133, fixed TACLS volume. * More D-2 tweaks: Lower DM mass further to aim for 2.8t total for DM (+ chute); that is a cool 700kg over (1.333x) the original GE spec, but weight growth that affected Apollo doubtless would have bit here too. Fix MMs to carry Nitrogen for Kerbal EVAs. Hopefully fix Skirt nodes not doing things in symmetry. * Convert textures to DDS (#89) * Fix Mission Module Ladder & Airlock Colliders * Fix Waterfall Rcs Sounds & Effects and Fix Engine Glow Clipping * Fix Solar Panel Sun catcher Transform * [D2] Let's make us survive a lunar reentry, shall we? And have a reasonable AoA doing so. * D2 Block II LES: use the same resource in PROPELLANT node as in ModuleFuelTanks >.> * Hopefully Fix D2 Mission Module Ladder Colliders * D2: Use probe and drogue from original version of Alternate Apollo; the v2 ones are busted. * D2: Fix AJ10-133 not being able to attach to nodes in 4x. * D2: Revert to original mission module models since at least on those kerbals don't get knocked off the ladder on spawn. * copypasta * Convert D-2 LES from HTPB to PBAN (it is maybe supposed to be double-base, who knows.) * Switch over to the new HS presets, Remove part values that the preset will override anyway * A few more capsule fixes, and fix D-2 to use EarlyLunar. * Increase ablator on Vostok/Voskhod. * Prep for v1.4 * Create makeMeta.py * initial setup of release CI script * Started working on adding TU Recoloring support to Gemini * Waterfall: less obnoxious audio template for the Gemini OAMS engine * Fix Apollo CM and HS thermal stats so it is reenterable again. * Add pressurant to engines/RCS and tanks @Capkirk123. Also correct Apollo RCS to use NTO/MMH as it is supposed to, not NTO/AZ50. * Prep for v1.5 * Add helium * Deprectate deprecated antenna. * Up ablator on Vostok/Voskhod to 450 units, fix mass. * Revise diameter (and mass) of D-2 HGA. Close #97 * Fix Vostok, Voskhod masses. * Fix typo in comment * Tweak Gemini lunar HS * Fix too-low LH2 and LOX on Gemini Equipment Section. Technically the batteries would have been swapped out for LH2 and LOX but we don't really have tank configs we can do that with. * Fix GeminiOAMS RCS alignment Engine models reused as RCS need useZaxis = True in moduleRCSFX * Mark B9PS as a dependency on CKAN The new BDB parts (Gemini, Mercury) use it. * Star-13E (Gemini Retro) should probably be CTPB. * Fix insufficient LH2 reserves on Gemini equipment section * Fix typo in Apollo SM Helium amount * Tweak GeminiBDB IVA Pilots were floating off their seat, heads were poking out of the capsule, and interior point of view was too high for both seeing out and looking a controls * Fix ROLib link in readme * Prep for v1.5.3 * Do not remove the apollo D2 if CH4 is installed * Revise dynasoar thermals to realistic values (#107) * Add missing `ignoreForIsp` for helium * Fix AcquireRange to make undocking possible * Fix AcquireRange to make undocking possible * Fix typo in description of Gemini retro (#112) * Replace Dynasoar with X-20 Moroz Dynasoar (#110) * Add Moroz Dynasoar * Update README.md * Deprecate uneeded old Dyna Parts * WF for new Dynasoar Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com> * Fix transparent hole on Gemini OAMS thrusters Now that DepthMask is on CKAN, we can depend it. * Fix #101 * Fix up CKAN dependencies * Fix .cfg typos fuelCrossFeed, skinMaxTemp, childStageOffset * Fix Missing DRE Needs * Fix .cfg typo * Add pressurefed tag to OAMS (#113) Add pressure fed tag to OAMS thrusters * Remove deprecated FASA Mercury and Gemini parts (#109) * Update script for KSP 1.12 * Manually update the .version file since Actions doesn't handle it for this repo * Add the Zenit camera system (#114) * Add 4kL fuel tank to D-2 1-engine Skirt Section (#115) Visually the 1-engine and 4-engine skirts have spherical fuel tanks of the same size but the 1-engine skirt was lacking the fuel tank config. * Untabify version file * Release prep * Fix cfg syntax errors (#118) * Fix :FOR[RealismOverhaul] in ROCapsules (#119) * Pretty-print the .version file * Add MM syntax validation action * Add Alternative Dynasoar cockpit (#121) Add alternative dynasoar cockpit with rounded nose * Update capsule thermals (#122) * Update capsule thermals Update capsule thermal properties, and patch maxtemps after RO global patches run. Everything now works mostly correctly, except for: Gemini needs inflated skinMaxTemp due to receiving excessive convective flux. Drag cube issue? Orion HS does not occlude Orion CM, which consequently cannot properly survive reentry. Drag cube issue. * Correct MM patching order, missing newlines * Missed one * Remove DRE patches Remove fancy DRE patches, they apparently get clobbered by a later RO pass anyway. Co-authored-by: Majorvader111 <comeon92rules@gmail.com> Co-authored-by: NathanKell <nathankell@gmail.com> Co-authored-by: Alvin Meng <35266431+al2me6@users.noreply.github.com> Co-authored-by: siimav <siim.aaver@gmail.com> Co-authored-by: jwvanderbeck <jwvanderbeck@gmail.com> Co-authored-by: Dan <papwr17@gmail.com> Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com> Co-authored-by: Degenerate Ground State <DegenerateGroundState@users.noreply.github.com> Co-authored-by: Stonesmile <62522391+StonesmileGit@users.noreply.github.com> Co-authored-by: LPG <lpgagnon@gmail.com> Co-authored-by: Ben <kalynndarcy@gmail.com> Co-authored-by: ZombieZilla <48612811+ZombieZilla@users.noreply.github.com> Co-authored-by: DRVeyl <DRVeyl@gmail.com> Co-authored-by: Arrowmaster <arrow@arrowmaster.net> Co-authored-by: HebaruSan <HebaruSan@users.noreply.github.com> * Mercury Weight Overhaul Based on data from "Design Mass Properties II", revise mass of all Mercury Components to more closely resemble their real counterparts. Also convert Mercury CM tanks to use SM-II tanks, such that adding more tanks or batteries increases capsule dry mass. * Remove doubled Helium resource Co-authored-by: Majorvader111 <comeon92rules@gmail.com> Co-authored-by: NathanKell <nathankell@gmail.com> Co-authored-by: Alvin Meng <35266431+al2me6@users.noreply.github.com> Co-authored-by: siimav <siim.aaver@gmail.com> Co-authored-by: jwvanderbeck <jwvanderbeck@gmail.com> Co-authored-by: Dan <papwr17@gmail.com> Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com> Co-authored-by: Degenerate Ground State <DegenerateGroundState@users.noreply.github.com> Co-authored-by: Stonesmile <62522391+StonesmileGit@users.noreply.github.com> Co-authored-by: LPG <lpgagnon@gmail.com> Co-authored-by: Ben <kalynndarcy@gmail.com> Co-authored-by: ZombieZilla <48612811+ZombieZilla@users.noreply.github.com> Co-authored-by: DRVeyl <DRVeyl@gmail.com> Co-authored-by: Arrowmaster <arrow@arrowmaster.net> Co-authored-by: HebaruSan <HebaruSan@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi again KSP-RO team,
This is like KSP-RO/RealismOverhaul#2612 but for ROCapsules.
Referencing KSP-CKAN/CKAN/pull/3525 so I can find this again later easily.
proxyline moved into itsPROPnode (see comments in Fix cfg syntax errors PorktoberRevolution/ReStocked#988 for some more discussion of the background of this and examples of mods that do it both ways)*added to an array index