Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trying to unlock a new comm tech level while editing a vehicle doesn't work #2408

Closed
Clayell opened this issue Jul 27, 2024 · 3 comments · Fixed by #2410
Closed

Trying to unlock a new comm tech level while editing a vehicle doesn't work #2408

Clayell opened this issue Jul 27, 2024 · 3 comments · Fixed by #2410

Comments

@Clayell
Copy link
Contributor

Clayell commented Jul 27, 2024

See video below:
https://youtu.be/faLrIdUkipY

@siimav
Copy link
Contributor

siimav commented Jul 27, 2024

No ksp.log

@Clayell
Copy link
Contributor Author

Clayell commented Jul 27, 2024

@siimav
Copy link
Contributor

siimav commented Jul 27, 2024

So the issue there is that the upgrade costs more than you have funds. The query that checks whether the upgrade can be afforded is inside RA itself and doesn't know anything about unlock credit. However if you had the funds then it would actually use up unlock credit and take nothing from funds.
I think the fix is to change the ResolveValidationError() code such that it feeds current unlock credit in there. The change needs to be done into RP-1 and to all other mods that have integrated with this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants