Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing ProcAvi shapes doesn't always work #644

Closed
rsparkyc opened this issue Apr 25, 2017 · 2 comments
Closed

Changing ProcAvi shapes doesn't always work #644

rsparkyc opened this issue Apr 25, 2017 · 2 comments
Labels

Comments

@rsparkyc
Copy link
Member

No description provided.

@rsparkyc
Copy link
Member Author

It seems like the first time you select a specific shape configuration, it doesn't load, but the next time you select it (by either looping through the whole set of shapes, or by going back), it does load. It's interesting to note that the attachment nodes do seem to move when you select different shapes, however the visual appearance of the shape does not change. It's like for some reason procedural parts isn't redrawing the shape, but I don't know what would be overridden in Procedural Avionics that would be blocking that behavior (especially on just the first time you view that shape)

@rsparkyc rsparkyc added the bug label Apr 25, 2017
@rsparkyc
Copy link
Member Author

Looks like using reflection to find the part volume is throwing errors sometimes, which invalidates the procedural part. However, procedural parts sends a message when volume is changed, so i think we can hook into that instead

rsparkyc added a commit to rsparkyc/RP-0 that referenced this issue May 30, 2017
Hooked into OnPartVolumeChanged event
rsparkyc added a commit that referenced this issue May 30, 2017
pap1723 added a commit that referenced this issue May 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant