Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SSTU engine cluster masses #1930

Merged
merged 2 commits into from
Oct 13, 2018
Merged

Conversation

MikeOnTea
Copy link
Contributor

SSTU's engine clusters calculate their masses wrong. For example, if you change from one engine to two, the mass triples instead of doubles iirc. Fix this by setting adjustMass to false, which i think was made for realfuels compatibility.

@stratochief66
Copy link
Member

RealFuels is a requirement for RO though.

@MikeOnTea
Copy link
Contributor Author

MikeOnTea commented Sep 27, 2018

Sure - i was trying to say "if that switch was made for us and it works, we probably should start using it".

@Bornholio
Copy link
Contributor

Bornholio commented Sep 29, 2018

diameter change worked okay, whatever is messed up in my install didn't seem like the =false gave a reasonable result, not sure if it was RF interaction. @blowfishpro do you have any insight? I know you contribute to SSTU

@blowfishpro
Copy link
Member

I don’t really know much about this area unfortunately

@MikeOnTea
Copy link
Contributor Author

MikeOnTea commented Sep 29, 2018

adjustMass = false disables SSTU's engine cluster mass calculations, because apparently RealFuels has its own calculation, and they don't play nice along each other. SSTU passes the number of engines in a cluster to RF, so RF can and does calculate the correct engine cluster mass just fine on its own.

Also, apparently the patch works for Bornholio as he mentioned on IRC, he just doesn't trust his SSTU installation.

@Bornholio
Copy link
Contributor

tested a bit more and mike is right, seems to be appropriate

@raidernick
Copy link
Contributor

So is this ready to merge or not I want to release the new RO and I'll leave this out if no responses?

@raidernick raidernick merged commit 4158d3d into KSP-RO:master Oct 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready to Merge? Is this ready to merge? Needs feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants