Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove kerbalCrewMass #2290

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Remove kerbalCrewMass #2290

merged 1 commit into from
Jul 3, 2020

Conversation

lamont-granquist
Copy link
Contributor

The way this is implemented in KSP generates bugs in mods. Technically
this is solvable in mods but they all need to be updated to delay the
code they are calling to FashionablyLate or BetterLateThanNever by
calling FixedUpdateAdd to schedule the analysis after the part is
updated in Part.FixedUpdate().

This is a gigantic pain in the ass.

The Kerbalism author has also found other areas where its deeply
annoying:

https://github.com/Kerbalism/Kerbalism/blob/475866007fb94684336e959a67ae933dc64c8771/GameData/KerbalismConfig/Profiles/Default.cfg#L2396-L2405

It affects both KER and MJ at the very least, and as I'd consider the
way it is implmented in KSP itself to be active hostile to mod
development and all it does is troll users, with the standard
recommendation to users being to turn it off, lets just turn it off.

The way this is implemented in KSP generates bugs in mods.  Technically
this is solvable in mods but they all need to be updated to delay the
code they are calling to FashionablyLate or BetterLateThanNever by
calling FixedUpdateAdd to schedule the analysis after the part is
updated in Part.FixedUpdate().

This is a gigantic pain in the ass.

The Kerbalism author has also found other areas where its deeply
annoying:

https://github.com/Kerbalism/Kerbalism/blob/475866007fb94684336e959a67ae933dc64c8771/GameData/KerbalismConfig/Profiles/Default.cfg#L2396-L2405

It affects both KER and MJ at the very least, and as I'd consider the
way it is implmented in KSP itself to be active hostile to mod
development and all it does is troll users, with the standard
recommendation to users being to turn it off, lets just turn it off.
@lamont-granquist
Copy link
Contributor Author

Think the Kerbalism author also mentioned it creates buoyancy issues and kerbals with the double-mass immediately sink and drown? Something like that.

@dgfl-gh
Copy link
Contributor

dgfl-gh commented May 22, 2020

Think the Kerbalism author also mentioned it creates buoyancy issues and kerbals with the double-mass immediately sink and drown? Something like that.

that is indeed an issue, but I've already found 2 ways to solve it:
the first (which works flawlessly in my testing) is simply increasing the kerbals' buoyancy;
the second is changing the initialMass field in the MODULE[KerbalEVA], which also works but is a lot more hacky and gives very weird results when taken too far.

But even if the sinking issue can be solved easily, the Δv readout issues are much larger. If those are unfixable, then it's a strong argument against having mass. BUT you could also argue that if those do indeed cause missions to fail unexpectedly, then it means that 100kg per crew member are a non-insignificant part of the payload, and thus completely removing them would be unrealistic.

@lpgagnon
Copy link
Contributor

Supposing 100kg/crew is significant enough that it shouldn't be removed entirely, how about just bumping up the mass of capsules by a corresponding amount? It'd make non-full capsules too heavy, but that seems niche enough not to worry about.

@AnticlockwisePropeller
Copy link
Contributor

My only qualm about adding the 100kg to the base mass of capsules is whether or not station habs, etc. are included in that. They often contain capacity for quite a few kerbals, but would typically be launched empty. Therefore, simply writing a patch to add 100kg to any part that contains crew would not be ideal. Is there a station/capsule-specific tag that already exists, to make applying the extra mass easier? Doing it individually per-part would be a pain.

Also, sat in a grey area between station habs and capsules are the crew cabin parts, which can potentially be used as either, depending on circumstance. Should these have the mass included, or not?

@jwvanderbeck
Copy link
Contributor

Personally, I think the 100kg crew mass is pointless and if it causes so many problems just remove it. I never care about it one way or the other in my own games. If you are playing Sandbox then the mass is almost surely irrelevant, and in career by the time I'm lifting Kerbals I've already been lifting far heavier things.

Just remove it and be done with it.

@lpgagnon
Copy link
Contributor

lpgagnon commented Jul 2, 2020

Another small argument in favor of removal: the "double mass" doesn't just apply to kerbals walking around, it seems to also apply to kerbals sitting in an External Command Seat, increasing rover mass by ~200kg per passenger instead of ~100

@DRVeyl DRVeyl merged commit 30f705a into KSP-RO:master Jul 3, 2020
siimav added a commit that referenced this pull request Aug 1, 2021
siimav added a commit that referenced this pull request Nov 4, 2021
siimav pushed a commit that referenced this pull request Feb 6, 2022
* Revert "Remove kerbalCrewMass (#2290)"

* No, KSP, we don't want you to adjust the mass of our crewed parts

* Configure mass for KSP 1.11+ jetpack and chute

* Make sure only KSP 1.11+ installs get crew mass

* Change EVA fuel to Nitrogen and increase Kerbal Carry Capacity

* Also change EVA fuel resource for 1.10

Co-authored-by: siimav
Capkirk123 added a commit to Capkirk123/RealismOverhaul that referenced this pull request Apr 2, 2022
* Add RO Support for ROTanks KatnissTanks

* Add support for Photon Corp RSRM and RSRMV. Waterfall configs only

* Fix Photon Corp WaterFall glow clipping

* ROWaterfall: fix auto-config for derived MEC

* Remove support for ProcFairings pre-v6

Fix PF v6 mass calculations by using the provided decouplerMassMult/decouplerMassBase tooling.  Previously, disabling the decoupler was not giving a mass savings.

* Fix R-4D-11 TF config (KSP-RO#2582)

was using wrong config name in selector

* Add PhotonCorp RealPlume configs for RSRM and RSRMV

* Increase J57-P-8 temp limit (KSP-RO#2589)

Increase the temperature limit of the J57-P-8 to get it a bit closer to it's advertised performance, and more competitive with RD-9B

Also edit J48 description to be less confusing

* Engine config for Filament Wound Casing RSRM (KSP-RO#2587)

* Add source example to Engine Config Template

* Add RSRM FWC-SRM config

* Link PhotonCorp RSRM color to engine config

* Add tagging system for ModuleCargoPart (KSP-RO#2591)

Every part that doesn't have ROCargoConfig tag will be stripped of it's ModuleCargoPart PM.

* Basic configs for KSP 1.11+ kerbals (KSP-RO#2537)

* Revert "Remove kerbalCrewMass (KSP-RO#2290)"

* No, KSP, we don't want you to adjust the mass of our crewed parts

* Configure mass for KSP 1.11+ jetpack and chute

* Make sure only KSP 1.11+ installs get crew mass

* Change EVA fuel to Nitrogen and increase Kerbal Carry Capacity

* Also change EVA fuel resource for 1.10

Co-authored-by: siimav

* Add support for RMM (KSP-RO#2585)

Add engine and Waterfall configs for RMM by EStreetrockets.

* Add P&W Model 304 (KSP-RO#2581)

* Update version to v14.10.0.0

* Added configs for two additional sizes of RCS Blocks

* Configured RCS Blocks with Variants that Squad added in 1.11

* Adjust tank masses when LH2 is loaded (KSP-RO#2578)

Decrease the tankage mass of all tanks except balloon when LH2 is loaded. This is to simulate the fact that LH2 is extremely light, and requires much less structural mass to support.

The 80% mass reduction seems to accurately simulate CBC and SII/SIV, without making smaller stages like DCSS significantly underweight.

* Add restart timer to RD-119, S5.92, update descriptions (KSP-RO#2592)

* Add restart timer to RD-119

Add restart timer to RD-119 to prevent it from staying in pumped idle forever. Due to lack of data, we're going with 90 minutes.

* Add more descriptions

Add restart windows to descriptions of applicable engines, and add restart window to the S5.92 and S5.98M

* Add RO configs for New Tantares Mir station parts revamp. (KSP-RO#2515)

* Change to 1.12's new stock RCS blocks (KSP-RO#2594)

* MLI Settings Use RF+PartUpgrades (KSP-RO#2595)

Remove MLI definitions from tanks, and instead use part upgrades to upgrade all tanks at once.  RF implements default PartUpgrades.  RP-0 PR will address separately.

* Add RCSBlock so older craft still load (KSP-RO#2576)

* Revert "Change to 1.12's new stock RCS blocks (KSP-RO#2594)"

This reverts commit b59d721.

* Fix broken tech transfer F-1->F-1A (can't have spaces)

* Add SolarConfig support for multiple identical solar modules (KSP-RO#2599)

* Rename Integral to Isogrid in part title / description but leave RF tank type Integral so as to not break craft

* ROWaterfall: colorful plumes
April Fools, makes all Waterfall plumes rainbow-colored on April 1st.
To disable (effective on game restart), create an empty file named
`GameData/RealismOverhaul/Plugins/PluginData/DisableRainbowPloom`.

* ROWaterfall: support useRelativeScaling with hybrid plumes

* ROWaterfall: import templates from @Katniss218

* Add RD-0120T, fix RD-0120, 701, 704 (KSP-RO#2549)

* Add Rocketdyne G-1 (KSP-RO#2598)

Add config for Rocketdyne G-1 (NOMAD).

* Add more resource boiling points, move resource prices to RP-1 (KSP-RO#2600)

* Near Future Propulsion updates (KSP-RO#2574)

* SSME variants and triprop support (KSP-RO#2569)

Update configs to use MBEC instead of MEC

* Near future Launch Vehicles Support (KSP-RO#2567)

Add support for Nertea's Near Future Launch Vehicles.

* High Performance Prototypes (KSP-RO#2603)

Add RS-30, RD301 config, update RD-701, 704, and LR129 configs. Add support for ROE LR129, RD301, RD270.

* BDB Keyhole Parachute Fix (KSP-RO#2601)

* Dynamic Part Hider (KSP-RO#2586)

Adds a system to dynamically hide parts in the VAB/SPH and RnD building based on filters.

Implements a filters for hiding speculative parts based on a difficulty setting that is save independent.

* Add speclevel tagging to engines, fix techTransfer (KSP-RO#2606)

Add specLevel tagging to engine configs, and correct the ordering of techTransfer tags.

* Feed 1.12 DLLs to build scripts

* Update .version file script to target KSP 1.12

* Update version to v14.11.0.0

* Fix proton verniers (KSP-RO#2611)

Apply ignition, ullage and pressurefed tags to Proton verniers and 3rd stage

* Finish transfering RO config of ProcParts

Last value that hasn't already been pulled from ProcParts into RO

* Fix cfg syntax errors (KSP-RO#2612)

* Move fuel property data to RF (KSP-RO#2614)

Move thermal data to RF, where it probably belongs, and add tank definitions for liquid Nitrogen and liquid Helium

* Fix cfg error: invalid use of OR inside HAS (KSP-RO#2616)

* Fix Inconsistent CrewCapacity

PART.CrewCapacity not PART.crewCapacity

* Globally set applyKerbalMassModification

Disable KSP 1.12 reducing part mass based on crew capacity by default.  Override if desired in later pass.  This is because RO by convention assigns part masses without the crew, opposite a later KSP/stock assumption.
Based on stock Physics.cfg, set kerbalCrewMass and perSeatReduction to same value (the mass of the kerbal) and perCommandSeatReduction to include jetpack + parachute.
Since RO is 1.12-only, remove older version guards in NEEDS
Warning: don't set perCommandSeatReduction to 0, it breaks code in kerbal jumping resulting in infinte force applied, which crashes KSP after causing a NaN position/orbit.

* Change specparts default to be Speculative

This feels like a reasonable midway between Show All The Things and Show None Of The Things.

* Fix RD-107 and RD-108

Fix various issues in the RD-107 and RD-108 configs, including incorrect masses, and the 11D511/11D512 configs being swapped.

* Fix config names

Fix 11D511/11D512 names since this is savebreaking anyway

Co-authored-by: Dan <papwr17@gmail.com>
Co-authored-by: stonesmileGit <luddeboda99@gmail.com>
Co-authored-by: Alvin Meng <alvin.q.meng@gmail.com>
Co-authored-by: DRVeyl <DRVeyl@gmail.com>
Co-authored-by: Louis-Philippe Gagnon <lpgagnon@gmail.com>
Co-authored-by: Stonesmile <62522391+StonesmileGit@users.noreply.github.com>
Co-authored-by: siimav <siim.aaver@gmail.com>
Co-authored-by: GitHub Actions Bot <>
Co-authored-by: D0m1nu2 <75164010+D0m1nu2@users.noreply.github.com>
Co-authored-by: jimmymcgoochie <58994285+jimmymcgoochie@users.noreply.github.com>
Co-authored-by: NathanKell <nathankell@gmail.com>
Co-authored-by: Vieju17 <101110510+Vieju17@users.noreply.github.com>
Co-authored-by: HebaruSan <HebaruSan@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants