Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use DECLARE_FLEX_ARRAY() helper in drivers/net/ethernet/mellanox/mlx5/core/en_tc.h #222

Closed
GustavoARSilva opened this issue Sep 26, 2022 · 0 comments
Closed

Use DECLARE_FLEX_ARRAY() helper in drivers/net/ethernet/mellanox/mlx5/core/en_tc.h #222

GustavoARSilva opened this issue Sep 26, 2022 · 0 comments
Assignees
@GustavoARSilva
Labels
[Idiom] fake flexible array [PATCH] Accepted A submitted patch has been accepted upstream [PATCH] Exists A patch exists to address the issue [Refactor] 0-element array Conversion away from zero-length array

Comments

@GustavoARSilva
Copy link
Collaborator 

diff -u -p ./drivers/net/ethernet/mellanox/mlx5/core/en_tc.h /tmp/nothing/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h
--- ./drivers/net/ethernet/mellanox/mlx5/core/en_tc.h
+++ /tmp/nothing/drivers/net/ethernet/mellanox/mlx5/core/en_tc.h
@@ -98,7 +98,6 @@ struct mlx5_flow_attr {
        /* keep this union last */
        union {
                struct mlx5_esw_flow_attr esw_attr[0];
-               struct mlx5_nic_flow_attr nic_attr[0];
        };
 };
@GustavoARSilva GustavoARSilva self-assigned this Sep 26, 2022
@GustavoARSilva GustavoARSilva added the [PATCH] Exists A patch exists to address the issue label Sep 26, 2022
@GustavoARSilva GustavoARSilva mentioned this issue Sep 26, 2022
Closed
17 tasks
intel-lab-lkp pushed a commit to intel-lab-lkp/linux that referenced this issue Sep 27, 2022
@GustavoARSilva @intel-lab-lkp
net/mlx5e: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
27e1c80 
Zero-length arrays are deprecated and we are moving towards adopting
C99 flexible-array members, instead. So, replace zero-length arrays
declarations in anonymous union with the new DECLARE_FLEX_ARRAY()
helper macro.

This helper allows for flexible-array members in unions.

Link: KSPP#193
Link: KSPP#222
Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
gal-pressman pushed a commit to Mellanox/nic-kernel that referenced this issue Nov 30, 2022
@GustavoARSilva @gal-pressman
net/mlx5e: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
429cfbf 
Zero-length arrays are deprecated and we are moving towards adopting
C99 flexible-array members, instead. So, replace zero-length arrays
declarations in anonymous union with the new DECLARE_FLEX_ARRAY()
helper macro.

This helper allows for flexible-array members in unions.

Link: KSPP/linux#193
Link: KSPP/linux#222
Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Issue: 2114292
Change-Id: Iddcb079aafded8560cf40a07b24ca569a48a0f54
Issue: 2114292
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
ammarfaizi2 pushed a commit to ammarfaizi2/linux-fork that referenced this issue Dec 1, 2022
@GustavoARSilva
net/mlx5e: Replace zero-length arrays with DECLARE_FLEX_ARRAY() helper
5df5365 
Zero-length arrays are deprecated and we are moving towards adopting
C99 flexible-array members, instead. So, replace zero-length arrays
declarations in anonymous union with the new DECLARE_FLEX_ARRAY()
helper macro.

This helper allows for flexible-array members in unions.

Link: KSPP#193
Link: KSPP#222
Link: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Saeed Mahameed <saeedm@nvidia.com>
@GustavoARSilva GustavoARSilva added the [PATCH] Accepted A submitted patch has been accepted upstream label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@GustavoARSilva GustavoARSilva

Labels
[Idiom] fake flexible array [PATCH] Accepted A submitted patch has been accepted upstream [PATCH] Exists A patch exists to address the issue [Refactor] 0-element array Conversion away from zero-length array
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@GustavoARSilva