Clean some functions, start using yml files for configuration #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
into aggregate_export_fst() and use this function within the aggregate_export_fst_* functions. Pass functions that are to be used to process the different kinds of data.
Use Unicode instead of latin1-code to encode Greek character "my"
any more. Read from the yml files. Use new function get_calc_config().
No more need for the get_calc_info_<site>() functions
Remove package_file(). It is not used any more.
- use dplyr::mutate() - simplify variable names (e.g. simply "files", "file") - use do.call(rbind, lapply(...)) instead of for loop
Merge branch 'dev' into clean # Conflicts: # DESCRIPTION # R/read_mbr4.R
to (hopefully) remove last R CMD check warning
Merge branch 'dev' into clean # Conflicts: # R/group_datetime.R # R/import_operation_berlin_t.R # man/calculate_operational_parameters.Rd # man/calculate_operational_parameters_berlin_f.Rd # man/import_data_berlin_f.Rd # man/import_data_haridwar.Rd
- add commented lines for foldable sections - improve indentation - find better names (gather_cols -> parameters) - extract functions - use pipe operator - use kwb.utils::removeColumns()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please look at #18 first
aggregate_export_fst_*functions intoaggregate_export_fst()and use this function within theaggregate_export_fst_*functions. Pass functions that are to be used to process the different kinds of data.This change is