Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Win/Linux build broken after upgrade from dplyr 0.7.8 to 0.8.0.1 #18

Closed
mrustl opened this issue Feb 19, 2019 · 2 comments
Closed

Win/Linux build broken after upgrade from dplyr 0.7.8 to 0.8.0.1 #18

mrustl opened this issue Feb 19, 2019 · 2 comments
Assignees
@mrustl
Labels
bug
Milestone
v0.2.0

Comments

@mrustl
Copy link
Member

mrustl commented Feb 19, 2019

Broken build (2019-02-19): https://travis-ci.org/KWB-R/kwb.qmra/jobs/495452373#L1113

dplyr          0.8.0.1    2019-02-15 [1] CRAN (R 3.5.2)

Last working build (2019-02-14): https://travis-ci.org/KWB-R/kwb.qmra/jobs/493303971#L993

 dplyr          0.7.8    2018-11-10 [1] CRAN (R 3.5.2)
@mrustl mrustl added the bug label Feb 19, 2019
@mrustl mrustl added this to the v0.2.0 milestone Feb 19, 2019
@mrustl mrustl self-assigned this Feb 19, 2019
mrustl added a commit that referenced this issue Feb 19, 2019
@mrustl
try to fix tests (#18)
aeb91d9
@mrustl
Copy link
Member Author

mrustl commented Feb 19, 2019

@hsonne can you help me ?

@mrustl
Copy link
Member Author

mrustl commented Feb 21, 2019

Modifications made here solved the problem:
340c6b7#diff-52c8f95f7befa9f642c432d5277f09e4

Maybe reporting to dplyr developers is indicated......

@mrustl mrustl closed this as completed in 340c6b7 Feb 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrustl mrustl

Labels
bug
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
2 participants
@hsonne @mrustl