-
Notifications
You must be signed in to change notification settings - Fork 25
Improve fonts generation: enable CircleCI to build Docker image and fonts #50
Conversation
jobs: | ||
build: | ||
docker: | ||
- image: $DOCKER_USERNAME/katex-fonts:29d4cdbc |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this docker image live on docker hub? Why do we need environment variables for the user name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash Yes. Using environment variables is for easier maintenance.
|
||
- store_artifacts: | ||
path: fonts.tar.gz | ||
destination: fonts.tar.gz |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why bother storing artifacts if we're using this repo as a submodule?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess if we moved font creation into the main repo, we could avoid checking the built fonts in and instead grab the most recent artifact so that people don't have to build fonts themselves when doing KaTeX development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevinbarabash It's like screenshots. CircleCI doesn't commit files and they have to be manually committed.
@ylemkimon I've granted circleci access to the KaTeX organization and set up https://circleci.com/setup-project/gh/KaTeX/katex-fonts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I forgot about the second item on the checklist before merging this. 😞 I also should've asked more questions about how the docker image in https://github.com/KaTeX/katex-fonts/tree/docker gets built and how |
I totally messed that up https://circleci.com/gh/KaTeX/katex-fonts/2. |
I temporarily fixed it https://circleci.com/gh/KaTeX/katex-fonts/3. |
@kevinbarabash I've put my account to environment variables temporarily. |
I see, there's a way to set environment variables in the project settings part on circleci. |
@kevinbarabash But to test PRs, it seems we should hard-code the |
This PR is part of #12.
I think it's best to have another branch for
Dockerfile
and CircleCI configs to build the image. I've pushed the branch to https://github.com/KaTeX/katex-fonts/tree/docker:katex-fonts/.circleci/config.yml
Lines 1 to 19 in 8d0cfd8
Example CircleCI builds:
docker
branch, PR branchDOCKER_USERNAME
andDOCKER_PASSWORD
, respectively, in the environment variables