Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhacement/empty state in favorite screen #118

Merged

Conversation

mhmd-android
Copy link
Contributor

@mhmd-android mhmd-android commented Oct 3, 2023

Explanation of Changes in Pull Request

  1. MarketListContract:
  • In this section, a new parameter named showFavoriteEmptyState has been added to MarketListContract.State. This parameter is responsible for controlling the display and visibility of the empty state view when the favorite list is empty.
  1. MarketListViewModel:
  • The MarketListViewModel now incorporates the showFavoriteEmptyState property to manage the empty state view. When the showFavoriteList is true and the favorite list is empty, the EmptyStateAnimation Composable is displayed to provide a visually appealing and informative message to users.

  • The EmptyStateAnimation Composable itself has been introduced to display an animated message when the favorite list is empty. It utilizes Lottie animations to enhance the user experience.

These changes collectively improve the user experience by providing meaningful feedback when the favorite list is empty.

and finally, this is a sample:

sample

Please review the changes and let me know if you have any questions or need further clarification on any aspect of the code.
Close #115

Best regards

@Kaaveh Kaaveh self-requested a review October 4, 2023 03:22
@Kaaveh Kaaveh added enhancement New feature or request hacktoberfest labels Oct 4, 2023
@Kaaveh
Copy link
Owner

Kaaveh commented Oct 4, 2023

Hey @mhmd-android
Thanks for your amazing PR! 😍
Recently we setup ktlint and detekt on the project's CI. Please run the following command in your Android studio and fix issues (double press ctrl):

gradle lintKotlin

@Kaaveh Kaaveh merged commit e755452 into Kaaveh:master Oct 4, 2023
1 of 2 checks passed
@Kaaveh
Copy link
Owner

Kaaveh commented Oct 4, 2023

@mhmd-android Thanks for your another lovely PR! 🙌🏻
I hope received further PRs from you! 😍✌🏻

@mhmd-android mhmd-android deleted the enhacement/empty-state-in-favorite-screen branch October 4, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle Empty State for Favorite Screen
2 participants