-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhacement/empty state in favorite screen #118
Merged
Kaaveh
merged 9 commits into
Kaaveh:master
from
mhmd-android:enhacement/empty-state-in-favorite-screen
Oct 4, 2023
Merged
Enhacement/empty state in favorite screen #118
Kaaveh
merged 9 commits into
Kaaveh:master
from
mhmd-android:enhacement/empty-state-in-favorite-screen
Oct 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ty state animation
Hey @mhmd-android
|
Kaaveh
requested changes
Oct 4, 2023
library/designsystem/src/main/java/ir/composenews/designsystem/component/MarketItem.kt
Outdated
Show resolved
Hide resolved
Kaaveh
approved these changes
Oct 4, 2023
@mhmd-android Thanks for your another lovely PR! 🙌🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation of Changes in Pull Request
showFavoriteEmptyState
has been added toMarketListContract.State
. This parameter is responsible for controlling the display and visibility of the empty state view when the favorite list is empty.The
MarketListViewModel
now incorporates theshowFavoriteEmptyState
property to manage the empty state view. When theshowFavoriteList
is true and the favorite list is empty, theEmptyStateAnimation
Composable is displayed to provide a visually appealing and informative message to users.The
EmptyStateAnimation
Composable itself has been introduced to display an animated message when the favorite list is empty. It utilizes Lottie animations to enhance the user experience.These changes collectively improve the user experience by providing meaningful feedback when the favorite list is empty.
and finally, this is a sample:
Please review the changes and let me know if you have any questions or need further clarification on any aspect of the code.
Close #115
Best regards