Optimize/price change colors in market list #164
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces dynamic color selection for the price change indicator in our app. The goal is to improve the visual representation of price trends and enhance the user experience based on the system theme (light or dark mode).
Changes Made
Added four new colors to our theme:
lightUptrendGreenfor indicating an upward price trend in light mode.darkUptrendGreenfor indicating an upward price trend in dark mode.lightDownTrendRedfor indicating a downward price trend in light mode.darkDownTrendRedfor indicating a downward price trend in dark mode.I have tested the changes on some different dynamic light and dark themes to ensure that the selected colors work well with our app's design and provide a clear representation of price trends.
Screenshots:
Thank you for your review and feedback.
#145