Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved TS accuracy for recent Control function change #144

Merged
merged 2 commits into from
Mar 18, 2020

Conversation

adam-stover
Copy link
Member

In previous version, the notation indicates that Control's callback has an optional parameter of type string or ActionWithPayload. However, we do not know the shape of the callback function's parameters. It is therefore more accurate to be vague concerning the cb's parameters.

This happens to double as a lint fix for >100 char line.

@abbeycampbell abbeycampbell merged commit 9e45335 into KabaLabs:staging Mar 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants