Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R 4.4.0 #79

Merged
merged 9 commits into from
Jun 6, 2024
Merged

R 4.4.0 #79

merged 9 commits into from
Jun 6, 2024

Conversation

calderjo
Copy link
Contributor

@calderjo calderjo commented Jun 5, 2024

This is to update the image to use R 4.4.0,

we used an internal method from the util package to list dependencies, seem like a refactor happened that cause the pipeline to break. the refactor seem minimal (it was to speed up windows installs), but i couldn't seem to decipher what datatype it wanted.

Easiest path forward is to integrate the old algo. into our image, and not depend on an internal method. cleaned it up to made it readable.
https://b.corp.google.com/issues/282922446

passed build in commit, aa5cf28

I'm new to r, bear with me

#chavezcalderon-q2-fixit

@calderjo
Copy link
Contributor Author

calderjo commented Jun 5, 2024

/gcbrun

@calderjo calderjo requested a review from djherbis June 6, 2024 16:59
Copy link
Contributor

@djherbis djherbis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been stuck for years, if this ends up working and gets released, mad props mate 👏
The R community will be happy.

@calderjo calderjo merged commit 20143c8 into main Jun 6, 2024
2 checks passed
@calderjo calderjo deleted the r-4-4-0 branch June 6, 2024 20:50
@Philmod
Copy link
Contributor

Philmod commented Jun 7, 2024

👏 👏 👏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants