updated loading pretrained model #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
properly raises error when the trained model path is incorrect, prints whether training is starting from scratch or from provided model path.
Kaixhin
requested changes
Aug 7, 2019
agent.py
Outdated
| elif args.model and not os.path.isfile(args.model): | ||
| raise FileNotFoundError(args.model) | ||
|
|
||
| else: |
There was a problem hiding this comment.
I would delete the else branch as this is the default and most common behaviour, so there should only be a need to signpost a trained model.
Co-Authored-By: Kai Arulkumaran <Kaixhin@users.noreply.github.com>
Co-Authored-By: Kai Arulkumaran <Kaixhin@users.noreply.github.com>
|
Applied your suggestions. Thanks for taking a look |
|
Ah sorry for not spotting earlier - we can now do |
|
Np. Done :) |
Kaixhin
approved these changes
Aug 8, 2019
BerenMillidge
pushed a commit
to BerenMillidge/Rainbow
that referenced
this pull request
Dec 20, 2019
updated loading pretrained model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
properly raises error when the trained model path is incorrect, prints whether training is starting from scratch or from provided model path.