Enhancement - Add more click options #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vacxe
reviewed
Jan 2, 2024
| data class LongClickConfig( | ||
| val xOffset: Float = 0F, | ||
| val yOffset: Float = 0F, | ||
| val durationMs: Long? = null |
There was a problem hiding this comment.
durationMs can be a first argument in performLongClick with default value. In most cases devs will prefer to override this parameter.
| data class DoubleClickConfig( | ||
| val xOffset: Float = 0F, | ||
| val yOffset: Float = 0F, | ||
| val delayMs: Long? = null |
There was a problem hiding this comment.
delayMs can be a first argument in performDoubleClick with default value.
Comment on lines
+3
to
+7
| enum class Offsets { | ||
| CENTER, CENTER_LEFT, CENTER_RIGHT, | ||
| TOP_CENTER, TOP_LEFT, TOP_RIGHT, | ||
| BOTTOM_CENTER, BOTTOM_LEFT, BOTTOM_RIGHT | ||
| } |
There was a problem hiding this comment.
I think will be better to use sealed class with objects for default offsets + data class for custom offsets to avoid duplication in LongClickConfig DoubleClickConfig and ClickConfig. As well it will be more straight forward.
Comment on lines
+7
to
+24
| internal fun TouchInjectionScope.createOffset( | ||
| offset: Offsets, | ||
| offsetX: Float? = null, | ||
| offsetY: Float? = null | ||
| ): Offset { | ||
| return when (offset) { | ||
| Offsets.CENTER -> center | ||
| Offsets.CENTER_LEFT -> centerLeft.copy(x = 1f) | ||
| Offsets.CENTER_RIGHT -> centerRight | ||
| Offsets.TOP_CENTER -> topCenter.copy(y = 1f) | ||
| Offsets.TOP_LEFT -> topLeft.copy(x = 1f, y = 1f) | ||
| Offsets.TOP_RIGHT -> topRight.copy(y = 1f) | ||
| Offsets.BOTTOM_CENTER -> bottomCenter | ||
| Offsets.BOTTOM_LEFT -> bottomLeft.copy(x = 1f) | ||
| Offsets.BOTTOM_RIGHT -> bottomRight | ||
| }.run { | ||
| copy(x = x + (offsetX ?: 0F), y = y + (offsetY ?: 0F)) | ||
| } |
There was a problem hiding this comment.
Applying offsetX offsetY to existing offset looks misleading to me. sealed class with default objects + data class will be more clear IMO
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend base actions