Created get_first_chat and search_chat_by_name methods! #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Improves close_when_message_successfully_sent method and logging
|
@Kalebu, could you please 👍 this? Some other developments/solutions may depend on it. Thanks! |
euriconicacio
changed the title
euriconicacio
changed the title
|
Thanks for taking your time contributing to this package Can you also add docs about the newly implemented methods to the README.md |
|
Absolutely @Kalebu, adding them right now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a resolution to issue #48 and further adventures, we are creating the following methods:
get_first_chat(self, ignore_pinned=True)method: opens the first chat on the left list. Since they are out of order in the code itself, the technique was to hit the search field and press the down arrow. This method receives as an argument ignore_pinned, a boolean value that indicates if pinned chats should be ignored when retrieving the first one (default value is True). Works like a charm.search_chat_by_name(self, query: str)method: searches for the first chat containing the query parameter - not case sensitive.Enjoy!