Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for normal/c2p1x1_5_c5_030.s #2

Closed
pawelmat opened this issue Feb 16, 2022 · 3 comments
Closed

Fix for normal/c2p1x1_5_c5_030.s #2

pawelmat opened this issue Feb 16, 2022 · 3 comments

Comments

@pawelmat
Copy link
Contributor

normal/c2p1x1_5_c5_030.s has an error in creating tempbuf for the last bitplane. Here's the fix:

Lines 169-172 should be removed:
lsl.l #6,d1 ; Swap/Merge 2x4, part 1
lsl.l #4,d3
or.l d1,d3
move.l d3,a4

And replaced by:
lsl.l #2,d1 ; Swap/Merge 2x4, part 1
or.l d1,d3
move.l d3,(a3)+

Line 195 should be removed:
add.l a4,d1
@Kalmalyzer
Copy link
Owner

Thanks for the heads up. Would you mind making a PR with the change too? I hear it gives Internet karma!

pawelmat added a commit to pawelmat/kalms-c2p that referenced this issue Mar 4, 2022
@pawelmat
Fix for issue Kalmalyzer#2
5fc0ae6
@pawelmat
Copy link
Contributor Author

pawelmat commented Mar 4, 2022

Done, PR#3

Kalmalyzer added a commit that referenced this issue Mar 7, 2022
@Kalmalyzer
Merge pull request #3 from pawelmat/master
da606fc 
Fix for issue #2
@Kalmalyzer
Copy link
Owner

Thanks for the fix!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kalmalyzer @pawelmat