Skip to content
This repository has been archived by the owner on Nov 27, 2023. It is now read-only.

UI is not handling END branch steps #1587

Open
kahboom opened this issue Mar 29, 2023 · 1 comment
Open

UI is not handling END branch steps #1587

kahboom opened this issue Mar 29, 2023 · 1 comment
Labels
bug Something isn't working visualization Relates to the integration visualization

Comments

@kahboom
Copy link
Collaborator

kahboom commented Mar 29, 2023

Describe the Bug

The frontend is not handling steps within a branch that are END steps (such as stop), and if you add one via YAML it causes the integration to break (see screenshots).

We currently treat steps that are available as either MIDDLE or END steps as MIDDLE steps, but sometimes we have steps that are only available as END steps. At the moment, there is only one example of such a step, and that's the stop step.

Right now, we are changing the stop step to be a MIDDLE step so as to not break the UI, but eventually we will need to handle these step types as END steps, to provide a better UX on the frontend. For example, if a branch that has a stop step should not have anything after it unless there is some other execution flow available (i.e. another branch).

Relates to #1562 and KaotoIO/kaoto-backend#586

Steps to Reproduce the Bug or Issue

Paste the following YAML into the source code editor.

- from:
    uri: activemq:queue:null
    steps:
    - choice:
        when:
        - steps:
          - to:
              uri: activemq:queue:null
          - stop: {}
        - steps: []
        - steps: []
    - to:
        uri: avro:null:null:null/null

Screenshots or Videos

image

image

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 0.30.0]
@kahboom kahboom added bug Something isn't working visualization Relates to the integration visualization labels Mar 29, 2023
Delawen pushed a commit to KaotoIO/kaoto-backend that referenced this issue Mar 30, 2023
Fixes: #586

This also applies a workaround for KaotoIO/kaoto-ui#1587, change the `stop` EIP to be `MIDDLE` type while it's actually an `END`. We need to get this back to be `END` once KaotoIO/kaoto-ui#1587 is implemented
@igarashitm igarashitm added this to the 1.2.0 milestone Jul 11, 2023
@Delawen Delawen removed this from the 1.2.0 milestone Jul 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working visualization Relates to the integration visualization
Projects
None yet
Development

No branches or pull requests

3 participants